[php-maint] Bug#580383: Bug#580383: Bug#580383: php-xml-parser uses deprecated eregi and reference of new object
thijs at debian.org
Tue Aug 31 21:07:09 UTC 2010
On Tue, August 31, 2010 20:16, Thomas Goirand wrote:
> Thijs Kinkhorst wrote:
>> Two questions:
>> 1) Why is it needed to pass the object by reference? It looks like it
>> just as well be passed by value.
>> 2) Why is this bug of grave severity? As I understand it, using this
>> generates notices of level E_DEPRECATED. The code functions just as it
> Hi Thijs,
> I have made the necessary corrections to the package. Attached is an
> interdiff between the 2 versions. Please have a quick look/review, and
> let me know if you think it's ok that I upload the amended version.
You're using "prereg_match" which I think is a misspelling of the
"preg_match" function. Did you test it?
I was wondering apart from this why you keep the ereg(i) calls. All
versions of PHP also support preg_match, so you can just replace them with
preg_match calls unconditionally.
More information about the pkg-php-maint