[php-maint] RFS: php-log (updated package)

Guillaume Delacour gui at iroqwa.org
Tue Nov 23 13:36:50 UTC 2010


Le lundi 22 novembre 2010 à 16:48 -0600, Jonathan Nieder a écrit :
> Hi Guillaume,
> 
> Guillaume Delacour wrote:
> 
> > I am looking for a sponsor for the new version 1.12.3-1
> > of my package "php-log".
> 
> I am not a cdbs or php expert, but this looks pretty good.
> 
> Some quick nitpicks:
> 
>  - Do you track your packaging with a vcs?  If not, why not? :)
>    (Mini-patches are easier to review.)

I added Vcs-{Browser,Svn} field.

> 
>  - This bumps the required debhelper compat level to 7.  Probably
>    worth mentioning in the changelog.

You're right, i forgot to mention this important change, done now.

> 
>  - I'm assuming the examples are still intended to be installed in
>    /usr/share/doc/php-log/examples, but the changelog item
> 
>      + Delete nonexistent docs/examples/
> 
>    does not make that so clear.

I rewrote the entry changelog.

> 
>  - Probably it would be simplest to combine the changelog entries
>    so there is exactly one entry for each ancestor of the current
>    version released in a Debian-derived distribution.

What do you mean ? Did you have an example ?
Thanks for all your suggestions, i have uploaded a fixed version on
mentors.

> 
> Please feel free to cc me if you have any questions.
> 
> Regards,
> Jonathan
> 
> _______________________________________________
> pkg-php-maint mailing list
> pkg-php-maint at lists.alioth.debian.org
> http://lists.alioth.debian.org/mailman/listinfo/pkg-php-maint

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Ceci est une partie de message num?riquement sign?e
URL: <http://lists.alioth.debian.org/pipermail/pkg-php-maint/attachments/20101123/4281ef1e/attachment.pgp>


More information about the pkg-php-maint mailing list