[php-maint] Alioth group membership / git access

John Morrissey jwm at horde.net
Mon Oct 18 15:07:51 UTC 2010


On Mon, Oct 18, 2010 at 05:31:04PM +0800, Thomas Goirand wrote:
> 2/ debian/watch
> 
> You souldn't incude "RC" in it, as the upstream author might release a
> new version with these letters in it.

I've tightened the regex:

http://download.pear.php.net/package/Crypt_Blowfish-([\d.]+(?:RC\d+)?).tgz

since I'd like to catch future RC releases. This regex should do it without
collateral damage.

> 4/ debian/control
> 
> Even if you don't use it yet, you can add the following:
> 
> Vcs-Browser: http://git.debian.org/?p=pkg-php/php-crypt-blowfish.git
> Vcs-Git: http://git.debian.org/git/pkg-php/php-crypt-blowfish.git
> 
> as it will be there {at the,after} the upload.

Ach so, I didn't add them before since I had thought it was poor form to use
them before the repo was available. As you say, they'll be in place
eventually.

> 3/ debian/copyright
> 
> There's not even an email address of the author... Yet, in
> Net_DNS-1.0.5/Net/* I found some. Please list them all, each author
> attached to it's author file. Some of the copyright holder are NOT the
> PHP group, which isn't what is said in your debian/copyright. Plus I
> could read:
> 
> * The majority of this is _NOT_ my code.  I simply ported it from the
> * PERL Net::DNS module.
> *
> * The author of the Net::DNS module is Michael Fuhr <mike at fuhr.org>
> * http://www.fuhr.org/~mfuhr/perldns/
> 
> this should be stated, and you should research under what license that
> Net::DNS perl module was, and talk about it.

I had looked into it earlier; Perl Net::DNS is distributed under the same
terms as Perl itself (GPL or artistic license). The artistic license allows
PEAR Net_DNS' use:

--
3. You may otherwise modify your copy of this Package in any way, provided
that you insert a prominent notice in each changed file stating how and
when you changed that file, and provided that you do at least ONE of the
following:

    a) place your modifications in the Public Domain or otherwise make them
    Freely Available, such as by posting said modifications to Usenet or an
    equivalent medium, or placing the modifications on a major archive site
    such as uunet.uu.net, or by allowing the Copyright Holder to include
    your modifications in the Standard Version of the Package.
--

I'll add these notes to debian/copyright.

Also, the only copyright notice in Net_DNS is for Eric Kilfoil
<eric at ypass.net>. Those who have worked on the PEAR module are listed as
"maintainers." Should I keep the single 'Upstream Authors' section in
debian/copyright and list all of them, or make some distinction between
those listed as "maintainers" and those who have an explicit copyright
notice?

> C/ php-services-weather
> 
> This is a CDBS package, I don't review / sponsor them, sorry (I don't
> have enough knowledge to understand all the "magic" behind CDBS, and my
> point of view with CDBS is that nobody does except the author of CDBS).
> 
> But having a quick look, your package has the same issues as the other
> ones above (misc_depends, etc), plus it depends on debhelper 5 which is
> surprising.

I left this as CDBS since the previous maintainer used it, since I imagined
it was bad form to change the build system completely in the first upload
after adopting.

I'll get rid of CDBS and move it to debhelper.

> Let me know when you have corrected *all* the above,

Will do. Thanks.

john
-- 
John Morrissey          _o            /\         ----  __o
jwm at horde.net        _-< \_          /  \       ----  <  \,
www.horde.net/    __(_)/_(_)________/    \_______(_) /_(_)__



More information about the pkg-php-maint mailing list