[php-maint] Bug#652599: php5: use_embedded_timezonedb.patch causes ext/date/lib/parse_tz.c to fail to compile

Dominic Scheirlinck dominics at gmail.com
Mon Dec 19 02:00:49 UTC 2011


Package: php5
Version: 5.3.8.0-1
Severity: normal

The quilt patch use_embedded_timezonedb.patch patches the
timelib_parse_tzfile function within ext/date/lib/parse_tz.c to look
like this:

  http://paste.debian.net/149580/

Specifically, the #ifdef ends before the closing brace of the 'if'
block it introduces (and the 'else' a line below), causing compilation
errors if HAVE_SYSTEM_TZDATA is not defined:

  php5-5.3.8.0/ext/date/lib/parse_tz.c:875: error: expected identifier
or ‘(’ before ‘else’
  php5-5.3.8.0/ext/date/lib/parse_tz.c:879: error: expected identifier
or ‘(’ before ‘return’
  php5-5.3.8.0/ext/date/lib/parse_tz.c:880: error: expected identifier
or ‘(’ before ‘}’ token

It looks to me like the '#endif' belongs after the closing brace and
'else', and before the start of the else block.





More information about the pkg-php-maint mailing list