[php-maint] Bug#618680: Bug#618680: php-image-barcode: Uses depreciated methods

[Tobias Frost]

Hallo Thomas,

here's some additional info which might save you some work
(but I suppose you already know it)

Upstream has already some suggestions in their bug tracking system which
solves the issues. 

I saw this after posting the bug report:
http://pear.php.net/bugs/search.php?cmd=display&package_name[]=Image_Barcode
namely 10594, 17531

Note: Also bug 17353 is annoying -- if you use Code 39 barcodes.)
The fix also works. 

I attach a diff against the debian version. (If you have use for it)

coldtobi

Am Donnerstag, den 17.03.2011, 23:54 +0800 schrieb Thomas Goirand:
> On 03/17/2011 11:14 PM, Tobias Frost wrote:
> > Package: php-image-barcode
> > Version: 1.1.1-1
> > Severity: minor
> > 
> > My php script on my debuggin machine tells me:
> > 
> > Deprecated: Assigning the return value of new by reference is deprecated in /usr/share/php/Image/Barcode.php on line 80
> > 
> > and later
> > 
> > Notice: Only variable references should be returned by reference in /usr/share/php/Image/Barcode.php on line 112
> > 
> > I think generally not a big deal (therfore minor) but when using a high verbosity level on php, my browser tells me:
> > The image “http://localhost/barcode_img.php” cannot be displayed, because it contains errors.
> > 
> > NB: the barcode_img.php is the exact copy of the file in the examples...
> 
> Hi,
> 
> Thanks for this report. FYI, I did at least 5 corrections to existing
> PEAR packages before the release of Squeeze for that exact issue. The
> patch should be fairly simple, and I will work on a new package for SID,
> in order to fix the issue.
> 
> IMHO, this issue deserves a severity higher than just "minor" though, as
> this is a "deprecated" issue that PHP is complaining about. Under
> certain circumstances (eg: with verbosity set to high, which often many
> people do in order to solve issues), the fact that the script does some
> error message can destroy your image output headers, which can be very
> annoying.
> 
> As I've been updating all of my packages one by one, this one will go on
> top of the todo.
> 
> Thanks again for your bug report,
> 
> Thomas Goirand (zigo)

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 618680.patch
Type: text/x-patch
Size: 553 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-php-maint/attachments/20110317/fdce570c/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 618680_2.patch
Type: text/x-patch
Size: 1387 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-php-maint/attachments/20110317/fdce570c/attachment-0003.bin>