[php-maint] Bug#619546: Bug#619546: php5-fpm init script failing with error code 1 regardless of failure

[Ondřej Surý]

Hi Eusebi,

thanks for the patch. You are absolutelly right. I really had a bad
luck with this php5-fpm.init script :-(.

5.3.6-6 with the fix is on it's way to unstable.

Ondrej

On Thu, Mar 31, 2011 at 00:06, Eusebi Giampaolo
<giampaolo.eusebi at yahoo.it> wrote:
> I haven't read all the thread but /etc/init.d/php5-fpm doesn't start
> php5-fpm on boot (while it start it if called from the shell)..
>
> I resolved the problem swapping the first two lines of the "start" case
> in /etc/init.d/php5-fpm.. something like:
>
> [patch]
> *** php5-fpm    2011-03-30 23:57:31.989484928 +0200
> --- /etc/init.d/php5-fpm        2011-03-30 23:58:21.073525751 +0200
> ***************
> *** 109,116 ****
>
>  case "$1" in
>      start)
> -       do_check $VERBOSE
>        [ "$VERBOSE" != no ] && log_daemon_msg "Starting $DESC" "$NAME"
>        case "$?" in
>            0)
>                do_start
> --- 109,116 ----
>
>  case "$1" in
>      start)
>        [ "$VERBOSE" != no ] && log_daemon_msg "Starting $DESC" "$NAME"
> +       do_check $VERBOSE
>        case "$?" in
>            0)
>                do_start
> [/patch]
>
> I think php5-fpm isn't starting because you're testing the return value
> of the wrong line..
>
> Am i right?
>
> Sorry for my english,
> by the way thanks for your work.
>
> Eusebi Giampaolo
>
>
>
>
> _______________________________________________
> pkg-php-maint mailing list
> pkg-php-maint at lists.alioth.debian.org
> http://lists.alioth.debian.org/mailman/listinfo/pkg-php-maint
>



-- 
Ondřej Surý <ondrej at sury.org>
http://blog.rfc1925.org/