[php-maint] RFS: php-net-smtp (updated package)

[Guillaume Delacour]

Le samedi 07 mai 2011 à 20:01 +0200, Ondřej Surý a écrit :
> Well... found some problems:
> 
> 1. guide.txt.gz is there twice.

Indeed, i've removed the old initial debian/docs file in the package.
I've uploaded the corrected package on mentors.

> 
> 2. Please check doc vs docs in /usr/share/php (PEAR seems to be using
> /usr/share/php/doc/<PACKAGE>/docs).

Unless i am wrong, this is done by /usr/share/cdbs/1/class/pear.mk :

[...]
PEAR_OLD_DOC_DIR = usr/share/php/docs/$(PEAR_PKG)
PEAR_NEW_DOC_DIR = usr/share/doc/$(DEB_PACKAGES)
[...]

# install everything in default locations
/usr/bin/pear \
        -c debian/pearrc \
        -d include_path=/usr/share/php \
        -d php_bin=/usr/bin/php \
        -d bin_dir=/usr/bin \
        -d php_dir=/usr/share/php \
        -d data_dir=/usr/share/php/data \
        -d doc_dir=/usr/share/php/docs \
        -d test_dir=/usr/share/php/tests \
        install --offline --nodeps -P $(DEB_DESTDIR)
$(PEAR_SOURCE_DIR)/package.xml

# move documentation to correct location
mkdir -p $(DEB_DESTDIR)$(PEAR_NEW_DOC_DIR)
cp $(PEAR_SOURCE_DIR)/package.xml $(DEB_DESTDIR)$(PEAR_NEW_DOC_DIR)

if [ -d $(DEB_DESTDIR)$(PEAR_OLD_DOC_DIR) ] ; then \

        mv -i $(DEB_DESTDIR)$(PEAR_OLD_DOC_DIR)/*
$(DEB_DESTDIR)$(PEAR_NEW_DOC_DIR); \

        rmdir $(DEB_DESTDIR)$(PEAR_OLD_DOC_DIR); \

        ln -s ../../doc/$(DEB_PACKAGES) \
             $(DEB_DESTDIR)$(PEAR_OLD_DOC_DIR);
fi ;

[...]

If it's not really ok, i'll have a look later.
Thanks for your review.

> 
> Please fix and ping me.
> 
> O.
> 
> On Sat, May 7, 2011 at 19:50, Ondřej Surý <ondrej at debian.org> wrote:
> > Again I am not very happy that clean target has additional
> > dependencies (dh-make-php which pulls php5-cli, etc.), but it's
> > nothing major...  will do the upload.
> >
> > O.
> >
> > 2011/5/7 Guillaume Delacour <gui at iroqwa.org>:
> >> Hello php team,
> >>
> >> I am looking for a sponsor for the new version 1.5.2-1
> >> of my package "php-net-smtp".
> >>
> >> The package can be found on mentors.debian.net:
> >> - URL: http://mentors.debian.net/debian/pool/main/p/php-net-smtp
> >> - Source repository: deb-src http://mentors.debian.net/debian unstable main contrib non-free
> >> - dget http://mentors.debian.net/debian/pool/main/p/php-net-smtp/php-net-smtp_1.5.2-1.dsc
> >>
> >> Thanks in advance.
> >>
> >> --
> >> Guillaume Delacour <gui at iroqwa.org>
> >>
> >> _______________________________________________
> >> pkg-php-maint mailing list
> >> pkg-php-maint at lists.alioth.debian.org
> >> http://lists.alioth.debian.org/mailman/listinfo/pkg-php-maint
> >>
> >
> >
> >
> > --
> > Ondřej Surý <ondrej at sury.org>
> > http://blog.rfc1925.org/
> >
> 
> 
> 

-- 
Guillaume Delacour <gui at iroqwa.org>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Ceci est une partie de message num?riquement sign?e
URL: <http://lists.alioth.debian.org/pipermail/pkg-php-maint/attachments/20110508/32998ff9/attachment.pgp>