[php-maint] Bug#670242: Bug#670242: php-db: Warnings about static calls to non-static methods from common.php

[Thomas Goirand]

On 04/26/2012 10:26 PM, TreeBoy wrote:
> Package: php-db
> Followup-For: Bug #670242
> 
> Dear Thomas,
> 
> I'm glad to be able to say that I have built the package by downloading DB-1.7.14.tgz, renaming it tp php-db-1.7.14.tar.gz and then running:
> dpkg-buildpackage -us -uc
> 
> This produced the following output which I hope is correct:
> $ dpkg-buildpackage -us -uc
> [...]

Well, you'd normally run git-buildpackage, but what you did is
a valid way to build as well, even though it may leave dirt in
your local Git repository (which you may don't care about
anyway).

> I then installed the package which has now removed the problem.

Cool. I'll wait for Ondrej and Thijs agreement about uploading,
since I was not the origin maintainer (just out of respect for
their past work), then I'll upload the fixed package.

> Bear in mind that my script is not too advanced at the moment:
> it merely does a username and sha1 lookup and then a list of
> a single table, without using prepared statements or anything,
> so I cannot call this a complete coverage test, but it has
> removed the problem I originally reported.

Well, it's still better than me doing zero functional testing
of the package, and your tests are helping and saving my time,
so thanks for doing it. Please note that building the package
in Squeeze will *fail*, as the version of PEAR isn't high
enough to handle the package.xml correctly. So a version
depends will be needed, which I will add before uploading.

Cheers,

Thomas