[php-maint] Bug#652599: Bug#652599: Bug#652599: Bug#652599: php5: use_embedded_timezonedb.patch causes ext/date/lib/parse_tz.c to fail to compile
ondrej at debian.org
Thu Feb 2 17:46:29 UTC 2012
On Thu, Feb 2, 2012 at 18:41, Joe Orton <jorton at redhat.com> wrote:
> On Wed, Feb 01, 2012 at 05:24:38PM +0100, sean finney wrote:
>> On Wed, Feb 01, 2012 at 01:36:31AM +0100, Ondřej Surý wrote:
>> > But if you provide a clean patch to fix the issue, I'll apply it in
>> > the git and it will be part
>> > of some next release.
>> We should make sure to bring the system tzdata patch author (Joe) into
>> the conversation as well. Maybe he's updated it already?
>> @Joe: Are you aware of the issue (compile failures when the sys tzdata
>> is applied but HAVE_SYSTEM_TZDATA is undefined)? We're using r7
>> of the patch, fwiw.
> No, what's the failure?
Specifically, the #ifdef ends before the closing brace of the 'if'
block it introduces (and the 'else' a line below), causing compilation
errors if HAVE_SYSTEM_TZDATA is not defined:
php5-184.108.40.206/ext/date/lib/parse_tz.c:875: error: expected identifier
or ‘(’ before ‘else’
php5-220.127.116.11/ext/date/lib/parse_tz.c:879: error: expected identifier
or ‘(’ before ‘return’
php5-18.104.22.168/ext/date/lib/parse_tz.c:880: error: expected identifier
or ‘(’ before ‘}’ token
It looks to me like the '#endif' belongs after the closing brace and
'else', and before the start of the else block.
i.e. compilate with: --with-system-tzdata=no
Ondřej Surý <ondrej at sury.org>
More information about the pkg-php-maint