[php-maint] debian/patches/053-extension_api.patch ?

[sean finney]

Hey Ondřej,

On Mon, Feb 06, 2012 at 03:18:06PM +0100, Ondřej Surý wrote:
> do you remember why did you change this:
> 
> +DEBIAN_PHP_API=`egrep -h '^#define ZEND_EXTENSION_API_NO|^#define
> ZEND_MODULE_API_NO|#define PHP_API_VERSION'
> $srcdir/Zend/zend_extensions.h $srcdir/Zend/zend_modules.h
> $srcdir/main/php.h | awk '{print $3}' | sed -e 's/^220/20/' | sort -n
> | tail -n 1`

It predates me, I'm pretty sure.  I.e. I don't know why we're looking in
all of those places, probably because they might not necessarily agree
or maybe not necessarily be present in all cases?  I think the only
change I've done in the above was to go from 2200/200 to 220/20 (i.e. to
account for 2010).

> +if echo "$CPPFLAGS $CFLAGS" | grep -q -- -D_FILE_OFFSET_BITS=64; then
> +  DEBIAN_PHP_API="${DEBIAN_PHP_API}+lfs"
> +fi
> +
>  if test -z "$EXTENSION_DIR"; then
> -  extbasedir=$ZEND_MODULE_API_NO
> +  extbasedir=$DEBIAN_PHP_API

And this was added to have an explicit/clean break with the ABI versioning
when LFS was enabled vs disabled.  My memory is fuzzy whether it was
*only* for breaking the ABI with installed debian / pecl stuff, or
whether it was to *maintain* a broken ABI with future upstream releases
as well (since they're still not enabling LFS by default, I believe).



	sean