[php-maint] Fixes for the PHP unit tests

[Ondřej Surý]

Thomas,

just to be sure. Have you tried your patches against vanilla PHP?

O.

On Mon, May 14, 2012 at 10:42 AM, Thomas Goirand <zigo at debian.org> wrote:
> Hi Ondrej,
>
> I have worked for fixing the unit tests of PHP itself, in the hope of
> activating them at build time before wheezy. The goal is that you fear
> less to break something as well, when doing security upgrades.
>
> The patches are there:
> http://pkg-php.alioth.debian.org/Fixes-basic-unit-tests
> http://pkg-php.alioth.debian.org/Fixed-other-unit-tests.patch
>
> The fixes are needed mainly because the output of var_dump() changed
> format over time, so then the --EXPECTF-- part is wrong, even though the
> test passes. It took me a long time to fix, even though it was most of
> the time very trivial fixes (it was just big...).
>
> There's more than 600 unit tests that are executed correctly. There's
> about 20 which I wasn't sure, so I didn't fix. And about a dozen more
> which I believe are completely broken.
>
> I hope that phpunit will soon make it to Wheezy (pending FTP-masters
> approval in the NEW queue), so we can go further.
>
> Do you think you can send this upstream?
>
> Thoughts?
>
> Thomas Goirand (zigo)



-- 
Ondřej Surý <ondrej at sury.org>