[php-maint] Fixes for the PHP unit tests
ondrej at debian.org
Mon May 14 11:45:35 UTC 2012
On Mon, May 14, 2012 at 1:10 PM, Thomas Goirand <zigo at debian.org> wrote:
> On 05/14/2012 05:11 PM, Ondřej Surý wrote:
>> just to be sure. Have you tried your patches against vanilla PHP?
> I did, and they apply cleanly. Only one of the hunks has a line offset
Not speaking about applying, but about results of the tests.
> BTW, why is the php package still using format 1.0? Would it be ok to
> switch to format 3.0 (quilt)? That'd be more easy to manage patches
> (with dpkg-source --commit). Is it because the clean target doesn't
> clean properly?
It would and patches would be welcomed.
> I'm currently trying to add the tests in the build, but one thing I'm
> not sure how to manage is that PHP might then build-depends on itself.
> Indeed, if we need phpunit to build, then phpunit depends on php. That
> might be very annoying for porters. Any thoughts on this?
Could you maybe elaborate more on what phpunit is and why it would be
needed to build php itself?
Ondřej Surý <ondrej at sury.org>
More information about the pkg-php-maint