[php-maint] Reboot Apache2 2.4 transition

[Arno Töll]

Hi,

On 07.05.2013 12:02, Ondřej Surý wrote:
> elsif ($dh{CONDITIONAL} !~ /^\w+$/) {
>         die "The conditional function name must only contain ASCII
> letters, numbers, and underscores\n";
> }
> 
> And the question is: "Could it work?"

Yeah, now that you mention it: We added that constraint because of some
fuckup in debhelper, see #660794. Sadly we cannot do much here, unless
we decide not to use the debhelper functions :(

Note that my patch was reverted later.


> $MPM gets eaten:

Yeah, that's #660794.

> Also it's quite unpleasant that you have to define the same (usually
> dummy) function in postrm, but I can live with that.

> One more thing – you are mentioning prerm in dh_apache2 documentation
> couple of times, but not touching it at all (OPTIONS section).

Right. But I think the maintscripts we touch is an implementation detail
so that maintainers should prepared for it. On the other hand, if we
find during the cycle that there is no reason to ever touch prerm, I
might fix the docs (maybe you want to file a bug if you care enough so
that I don't forget).

I looked at your patch, which eliminates "true", but breaks the template
which currently does:

debhelper/postinst-apache2:

if [ "$1" = "configure" ] && #CONDITIONAL_VARIABLE#; then

which I cannot easily replace to

if [ "$1" = "configure" ] #CONDITIONAL_VARIABLE# then

and let #CONDITIONAL_VARIABLE# expand to something like "&&
#USERSUPPLIED_CONDITIONAL#;" for the very same reason as for shell
expansion above: debhelper fucks up. :(

I guess this could be worked around, but I would rather live with that
and hope Joey changes his mind at some point again, or provides a
new/better API.

The more I think, the more I'm convinced we should rather do our own
substitution for our scripts. That's an ugly code duplication, but at
least we can make the conditional behave in a sane way ...



-- 
with kind regards,
Arno Töll
IRC: daemonkeeper on Freenode/OFTC
GnuPG Key-ID: 0x9D80F36D

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 900 bytes
Desc: OpenPGP digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-php-maint/attachments/20130508/f3cd968b/attachment.pgp>