[php-maint] Bug#759698: php5-fpm: php-fpm service script

[cydadmin]

Package: php5-fpm
Version: 5.4.4-14+deb7u14
Severity: normal

Dear Maintainer,
I'm running Wheezy and am working on hosting a site using php-fpm. The problem is that if something goes wrong during reload fpm immediately dies and nothing is reported to the user. Here is what I do and what is written in the log:

┌[cydadmin][web][ssh]:~
└$ sudo service php5-fpm reload
[ ok ] Reloading PHP5 FastCGI Process Manager: php5-fpm.
┌[cydadmin][web][ssh]:~
└$ sudo service php5-fpm status
[FAIL] php5-fpm is not running ... failed!

[29-Aug-2014 13:18:21] NOTICE: fpm is running, pid 3910
[29-Aug-2014 13:18:21] NOTICE: ready to handle connections
[29-Aug-2014 13:22:16] NOTICE: Reloading in progress ...
[29-Aug-2014 13:22:16] NOTICE: reloading: execvp("/usr/sbin/php5-fpm", {"/usr/sbin/php5-fpm", "--fpm-c\
onfig", "/etc/php5/fpm/php-fpm.conf"})
[29-Aug-2014 13:22:16] ERROR: [/etc/php5/fpm/pool.d/y-lan.se.conf:2] unknown entry 'error.log'
[29-Aug-2014 13:22:16] ERROR: Unable to include /etc/php5/fpm/pool.d/y-lan.se.conf from /etc/php5/fpm/\
php-fpm.conf at line 2
[29-Aug-2014 13:22:16] ERROR: failed to load configuration file '/etc/php5/fpm/php-fpm.conf'
[29-Aug-2014 13:22:16] ERROR: FPM initialization failed

The problem seems to be that:

1. Reload doesn't sanity check the config file before loading it.
2. The init script doesn't report failure on crash.
3. The init script even reports success if php-fpm isn't running.

┌[cydadmin][web][ssh]:~
└$ sudo service php5-fpm status
[FAIL] php5-fpm is not running ... failed!
┌[cydadmin][web][ssh]:~
└$ sudo service php5-fpm reload
[ ok ] Reloading PHP5 FastCGI Process Manager: php5-fpm.

Also: starting php-fpm with the script doesn't report whether or not the service was successfully started.

-- System Information:
Debian Release: 7.6
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'stable'), (200, 'testing')
Architecture: amd64 (x86_64)

Kernel: Linux 3.2.0-4-amd64 (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages php5-fpm depends on:
ii  dpkg              1.16.15
ii  libbz2-1.0        1.0.6-4
ii  libc6             2.19-4
ii  libcomerr2        1.42.5-1.1
ii  libdb5.1          5.1.29-5
ii  libgssapi-krb5-2  1.10.1+dfsg-5+deb7u2
ii  libk5crypto3      1.10.1+dfsg-5+deb7u2
ii  libkrb5-3         1.10.1+dfsg-5+deb7u2
ii  libmagic1         5.11-2+deb7u3
ii  libonig2          5.9.1-1
ii  libpcre3          1:8.30-5
ii  libqdbm14         1.8.78-2
ii  libssl1.0.0       1.0.1e-2+deb7u12
ii  libxml2           2.8.0+dfsg1-7+wheezy1
ii  mime-support      3.52-1
ii  php5-common       5.4.4-14+deb7u14
ii  tzdata            2014e-0wheezy1
ii  ucf               3.0025+nmu3
ii  zlib1g            1:1.2.7.dfsg-13

php5-fpm recommends no packages.

Versions of packages php5-fpm suggests:
pn  php-pear  <none>

-- Configuration Files:
/etc/php5/fpm/pool.d/www.conf [Errno 2] No such file or directory: u'/etc/php5/fpm/pool.d/www.conf'

-- no debconf information