[php-maint] Bug#783246: Bug#783246: php5en(dis)mod: mandatory space between semicolon and priority key

[Ondřej Surý]

Hi,

while I agree with you both that the priority parser should be more
relaxed about the whitespaces. The issue has a very easy fix - just fix
the whitespace to the "strict" format, and this change has a potential
to disrupt service for the people who already rely on the existing
strict behavior, so I don't think this is material for stable update.

However I have fixed this in next stable Debian (php-defaults_47), where
the php-helper will ignore any whitespace on the line (even the trailing
whitespace).

Cheers,
-- 
Ondřej Surý <ondrej at sury.org>
Knot DNS (https://www.knot-dns.cz/) – a high-performance DNS server
Knot Resolver (https://www.knot-resolver.cz/) – secure, privacy-aware,
fast DNS(SEC) resolver
Vše pro chleba (https://vseprochleba.cz) – Mouky ze mlýna a potřeby pro
pečení chleba všeho druhu

On Tue, Dec 13, 2016, at 22:27, J G Miller wrote:
> Package: php5-common
> Version: 5.6.28+dfsg-0+deb8u1
> Followup-For: Bug #783246
> 
> Allowing some white space on the priority line before the word priority
> and around the equals sign in the get_priority function would be most
> welcome.
> 
> This strictness results for me in duplicate symlinks with wrong
> priority 20 to keep appearing every time there is an update and
> hourly already loaded mail messages and the need for manual pruning.
> 
> --- php5/php5-helper.orig       2016-12-09 13:26:56.000000000 +0100
> +++ php5/php5-helper            2016-12-09 13:26:56.000000000 +0100
> @@ -132,7 +132,7 @@
>      module_exists $modname || module_ret=$?
> 
>      if [ "$module_ret" -eq 0 ]; then
> -       priority=$(sed -ne "s/^; priority=\([0-9]\+\)$/\\1/p"
> $source_ini)
> +       priority=$(sed -ne
> "s/^;[[:space:]]*priority[[:space:]]*=[[:space:]]*\([0-9]\+\)$/\\1/p"
> $source_ini)
>         [ -z "$priority" ] && priority=20
>         echo $priority
>         return 0
> 
> Incidentally, why the double backslash on the reference 1, viz \\1,
> rather than the normal single backslash \1?
> 
> Thanking your for your support.
> 
> 
> -- Package-specific info:
> ==== Additional PHP 5 information ====
> 
> ++++ PHP 5 SAPI (php5query -S): ++++
> fpm
> cli
> 
> -- System Information:
> Debian Release: 8.6
>   APT prefers stable-updates
>   APT policy: (500, 'stable-updates'), (500, 'stable')
> Architecture: armel (armv5tel)
> 
> Kernel: Linux 3.16.0-4-kirkwood
> Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=ANSI_X3.4-1968)
> (ignored: LC_ALL set to C)
> Shell: /bin/sh linked to /bin/dash
> Init: systemd (via /run/systemd/system)
> 
> _______________________________________________
> pkg-php-maint mailing list
> pkg-php-maint at lists.alioth.debian.org
> http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-php-maint