[php-maint] Bug#815987: libphp-adodb requires porting to php7.0; mysql_pconnect is removed

[Paul Gevers]

Package: libphp-adodb
Version: 5.15-1
Severity: important

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

In response to the announcement¹ that strech will ship with php7.0 I tested my
package cacti (which depends on libphp-adodb) with php7.0 in a clean sid lxc
container. However, the error logs report (password not stripped, I don't care
in this case):

[Fri Feb 26 11:16:31.154718 2016] [:error] [pid 24140] [client ::1:35672] PHP Fatal error:  Uncaught Error: Call to undefined function mysql_pconnect() in /usr/share/php/adodb/drivers/adodb-mysql.inc.php:480\nStack trace:\n#0 /usr/share/php/adodb/adodb.inc.php(733): ADODB_mysql->_pconnect('localhost', 'cacti', 'AoCcMn8ZNg48', 'cacti')\n#1 /usr/share/php/adodb/adodb.inc.php(4799): ADOConnection->PConnect('localhost', 'cacti', 'AoCcMn8ZNg48', 'cacti')\n#2 /usr/share/cacti/site/lib/database.php(51): ADONewConnection('mysql')\n#3 /usr/share/cacti/site/include/global.php(212): db_connect_real('localhost', 'cacti', 'AoCcMn8ZNg48', 'cacti', 'mysql', '', false)\n#4 /usr/share/cacti/site/include/auth.php(25): include('/usr/share/cact...')\n#5 /usr/share/cacti/site/index.php(25): include('/usr/share/cact...')\n#6 {main}\n  thrown in /usr/share/php/adodb/drivers/adodb-mysql.inc.php on line 480

When I use codesearch.d.n to search for where mysql_pconnect is implemented, I
find a lot of hits in the php5 package (test suite) which say:

Deprecated: mysql_pconnect(): The mysql extension is deprecated and will be removed in the future: use mysqli or PDO instead in %s on line %d

My understanding is that mysql_pconnect got removed from the php package and
libphp-adodb needs to be ported to php7.0 by using mysqli instead of
mysql_pconnect.

Thanks for considering.
Paul

¹ https://lists.debian.org/debian-devel-announce/2016/01/msg00002.html

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQEcBAEBCAAGBQJW0EPBAAoJEJxcmesFvXUKAs4H/RjDD5qesKe+YCvsNsiK2RcD
M0/lX9Ib83Wt1vNR/h8/rt4cs65M52WMUcdBkfVffKVsm7NSZNHTIibNdiXAj8Rk
XK5zmel0wqQiiUaqtpov4JAXa5LAorZWsLEEu/hO8ODCYCoHTOfFjFhHp5edNz0t
hm5yCHqTxyo4rJddtOU1IfgnbL3M7ms4PPMXZ72BjGAtB+kJKrZIJTQUy3KKk8CU
/VFvFOFe2+Xr55HeFuWklFSONAoPus/o7t8BvY8ycJv48eKZBCHA69s5ZCdOxA3B
babiirbnyN5duPQSNyrkgDV+wpRMD4gNd3zpibBIMDyLf93kmNmyNQOU/HqpldI=
=py44
-----END PGP SIGNATURE-----