[php-maint] Bug#818102: Bug#818102: php5-fpm: sed expression in /etc/init.d/php5-fpm init script should allow for multiple spaces and/or tabs

[Ondřej Surý]

Thanks. I merged this into src:php7.0 packages.

I'll look into getting this into stable release.

Cheers,
-- 
Ondřej Surý <ondrej at sury.org>
Knot DNS (https://www.knot-dns.cz/) – a high-performance DNS server

On Sun, Mar 13, 2016, at 18:41, J G Miller wrote:
> Package: php5-fpm
> Version: 5.6.17+dfsg-0+deb8u1
> Severity: normal
> 
> In the /etc/init.d/php5-fpm script, the PIDFILE path is extracted from
> the /etc/php5/fpm/php-fpm.conf configuration file.
> 
> Multiple white space, both space and tabs, are allowed in this file
> and therefore the initscript should be corrected to allow for this
> situation.
> 
> Strictly speaking, the current expression is incorrect since it actually
> allows mulitple or zero "=" (equal signs) along with multiple or zero
> spaces
> after the string pid.
> 
> Using the sed "\s" white space (space or tab) notation, the proposed
> correction is as follows.
> 
> --- php5-fpm.orig       2015-04-16 16:26:58.000000000 +0100
> +++ php5-fpm            2015-04-16 16:26:58.000000000 +0100
> @@ -16,7 +16,7 @@
>  NAME=php5-fpm
>  DAEMON=/usr/sbin/$NAME
>  DAEMON_ARGS="--daemonize --fpm-config /etc/php5/fpm/php-fpm.conf"
> -CONF_PIDFILE=$(sed -n 's/^pid[ =]*//p' /etc/php5/fpm/php-fpm.conf)
> +CONF_PIDFILE=$(sed -n 's/^pid\s*=\s*//p' /etc/php5/fpm/php-fpm.conf)
>  PIDFILE=${CONF_PIDFILE:-/run/php5-fpm.pid}
>  TIMEOUT=30
>  SCRIPTNAME=/etc/init.d/$NAME
> 
> 
> 
> -- System Information:
> Debian Release: 8.3
>   APT prefers stable-updates
>   APT policy: (500, 'stable-updates'), (500, 'stable')
> Architecture: armhf (armv7l)
> 
> Kernel: Linux 3.10.17.1-wand-armhf.com (SMP w/4 CPU cores)
> Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=ANSI_X3.4-1968)
> (ignored: LC_ALL set to C)
> Shell: /bin/sh linked to /bin/dash
> Init: sysvinit (via /sbin/init)
> 
> Versions of packages php5-fpm depends on:
> ii  init-system-helpers  1.22
> ii  libapparmor1         2.9.0-3
> ii  libbz2-1.0           1.0.6-7+b3
> ii  libc6                2.19-18+deb8u3
> ii  libcomerr2           1.42.12-1.1
> ii  libdb5.3             5.3.28-9
> ii  libgssapi-krb5-2     1.12.1+dfsg-19+deb8u2
> ii  libk5crypto3         1.12.1+dfsg-19+deb8u2
> ii  libkrb5-3            1.12.1+dfsg-19+deb8u2
> ii  libmagic1            1:5.22+15-2+deb8u1
> ii  libonig2             5.9.5-3.2
> ii  libpcre3             2:8.35-3.3+deb8u2
> ii  libqdbm14            1.8.78-5+b1
> ii  libssl1.0.0          1.0.1k-3+deb8u4
> ii  libsystemd0          215-17+deb8u3
> ii  libxml2              2.9.1+dfsg1-5+deb8u1
> ii  mime-support         3.58
> ii  php5-cli             5.6.17+dfsg-0+deb8u1
> ii  php5-common          5.6.17+dfsg-0+deb8u1
> ii  php5-json            1.3.6-1
> ii  tzdata               2015g-0+deb8u1
> ii  ucf                  3.0030
> ii  zlib1g               1:1.2.8.dfsg-2+b1
> 
> php5-fpm recommends no packages.
> 
> Versions of packages php5-fpm suggests:
> ii  php-pear  5.6.17+dfsg-0+deb8u1
> 
> Versions of packages php5-common depends on:
> ii  libc6   2.19-18+deb8u3
> ii  lsof    4.86+dfsg-1
> ii  psmisc  22.21-2
> ii  sed     4.2.2-4+b1
> ii  ucf     3.0030
> 
> Versions of packages php5-common suggests:
> pn  php5-user-cache  <none>
> 
> -- no debconf information
> 
> _______________________________________________
> pkg-php-maint mailing list
> pkg-php-maint at lists.alioth.debian.org
> http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-php-maint