[Pkg-php-pecl] php-imagick 3.4.0~rc6-1 test status?

Nish Aravamudan nish.aravamudan at canonical.com
Fri Feb 26 02:31:57 UTC 2016


On 25.02.2016 [20:15:42 +0100], Ondřej Surý wrote:
> I would say no objections, anything to make it work.

I'm actually making some progress using phpunit, we are missing several
test deps to actually pass the tests. But I think one of the major
reasons both Debian & Ubuntu fail the tests is that imagemagick is
unusable with multiple threads (segfaults all over the php-imagick
testsuite). I am manually fixing up my autopkgtest env policy.xml as per
the OpenMP section of https://github.com/mkoppanen/imagick, but I am not
sure how to express that in the debian/test/control file.  It seems like
I should be able to use a phpunit bootstrap file, but it seems to not be
working -- but if I put the same line (again as mentioned on the above
page) in each test, it does work... I guess the bootstrap is just
executed once and exports whatever variables are defined?

-Nish

> O.
> -- 
> Ondřej Surý <ondrej at sury.org>
> Knot DNS (https://www.knot-dns.cz/) – a high-performance DNS server
> 
> On Thu, Feb 25, 2016, at 17:14, Nish Aravamudan wrote:
> > On 25.02.2016 [09:48:53 +0100], Ondřej Surý wrote:
> > > Hi Nish,
> > > 
> > > > Is there any plan for mitigating this?
> > > 
> > > The current plan is to wait for you to fix this and merge your work to
> > > the package :). Joining alioth.debian.org pkg-php group would allow you
> > > to commit any changes you need directly to our git repositories and I
> > > can sponsor the uploads.
> > 
> > Heh :) Fair enough! Request to join submitted.
> > 
> > > (Sorry, don't have any better plans then that at the moment...)
> > 
> > No, totally fine! Would there be any objection to reverting the phpunit
> > change (as I don't see how it could have worked). I'm now down to one
> > failure when running the tests manually (via `make test`) with PHP7.0,
> > which I think is due to a versioning issue with imagemagick. Will send
> > the diff to Debian once I have it working.
> > 
> > -Nish
> > 
> > > Cheers,
> > > -- 
> > > Ondřej Surý <ondrej at sury.org>
> > > Knot DNS (https://www.knot-dns.cz/) – a high-performance DNS server
> > > 
> > > On Thu, Feb 25, 2016, at 01:06, Nish Aravamudan wrote:
> > > > Hi all,
> > > > 
> > > > I am helping migrate Ubuntu 16.04 to a PHP7.0-only base. As such, we
> > > > have sync'd php-imagick 3.4.0~rc6-1, but we are seeing test failures (as
> > > > is Debian with PHP5):
> > > > 
> > > > Ubuntu:
> > > > https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-xenial/xenial/amd64/p/php-imagick/20160224_165124@/log.gz
> > > > 
> > > > Debian:
> > > > https://ci.debian.net/data/packages/unstable/amd64/p/php-imagick/20160224_220652.autopkgtest.log.gz
> > > > 
> > > > I believe *all* the segmentation faults are because the default
> > > > imagemagick configuration is not single-threaded and is absolutely not
> > > > thread-safe :) In fact, the upstream php-imagick mentions this:
> > > > https://github.com/mkoppanen/imagick/blob/master/README.md in the OpenMP
> > > > section.
> > > > 
> > > > Once those are resolved, it seems some are due to dependencies on
> > > > imagmagick 7 in some tests. It seems like moving to phpunit isn't a
> > > > drop-in replacement, as run-tests.php has specific syntactical knowledge
> > > > of the tests/ file structure (e.g., SKIPIF). When running via
> > > > run-tests.php, these test are properly skipped, but not with phpunit.
> > > > There are more failures than just these version issues, but just wanted
> > > > to sync on this first.
> > > > 
> > > > Is there any plan for mitigating this? With the test failures, the
> > > > updated package won't get released in Ubuntu and I'd like to make sure
> > > > my changes are not a significant divergence from Debian's plans.
> > > > 
> > > > -Nish
> > > > 
> > > > -- 
> > > > Nishanth Aravamudan
> > > > Ubuntu Server
> > > > Canonical Ltd
> > 
> > -- 
> > Nishanth Aravamudan
> > Ubuntu Server
> > Canonical Ltd

-- 
Nishanth Aravamudan
Ubuntu Server
Canonical Ltd



More information about the Pkg-php-pecl mailing list