[Pkg-php-pecl] php-mf2 issue with latest pkg-php-tools

[Nish Aravamudan]

On 31.03.2016 [17:25:50 +0200], Mathieu Parent wrote:
> Hello Nish,
> 
> 2016-03-31 1:51 GMT+02:00 Nish Aravamudan <nish.aravamudan at canonical.com>:
> > On 30.03.2016 [16:38:29 -0700], Nish Aravamudan wrote:
> >> As I slowly rebuild all the php pecl/pear packages in 16.04, I hit the
> >> following:
> >>
> >> dpkg-gencontrol: error: bad line in substvars file
> >> debian/php-mf2.substvars at line 2
> >> dh_gencontrol.pkg-create-dbgsym: dpkg-gencontrol -pphp-mf2
> >> -ldebian/changelog -Tdebian/php-mf2.substvars -Pdebian/php-mf2 returned
> >> exit code 25
> >> debian/rules:4: recipe for target 'binary' failed
> >> make: *** [binary] Error 2
> >>
> >> I took a look in the schroot:
> >>
> >> # cat debian/php-mf2.substvars
> >> phpcomposer:name=mf2/mf2
> >> Binary file debian/php-mf2.substvars matches
> >> phpcomposer:Debian-require=php-cli, php-common
> >> phpcomposer:Debian-require-dev=phpunit (>= 3.7), phpunit (<< 3.8~~)
> >> phpcomposer:Debian-suggest=php-barnabywalters-mf-cleaner
> >> misc:Depends=
> >> misc:Pre-Depends=
> >>
> >> I think line 2 is from grep? Not sure why it happened, but I see a clone
> >> + grep in an strace.
> >
> > OK debugging it further, seems like an issue with Dh_Lib?
> >
> > dh_phpcomposer
> > Override: require-dev:phpunit/phpunit (>= 3.7, < 3.8~~) ->
> > require-dev:__override__/phpunit (>= 3.7, < 3.8~~).
> > grep -s -v phpcomposer:name debian/php-mf2.substvars
> > grep -s -v phpcomposer:description debian/php-mf2.substvars
> > grep -s -v phpcomposer:Debian-require debian/php-mf2.substvars
> > grep -s -v phpcomposer:Debian-require-dev debian/php-mf2.substvars
> > grep -s -v phpcomposer:Debian-suggest debian/php-mf2.substvars
> >
> > given the initial results from pkgtools:
> >
> > # pkgtools -v --sourcedirectory . phpcomposer substvars > debian/php-mf2.substvars
> > # cat debian/php-mf2.substvars
> > phpcomposer:name=mf2/mf2
> > phpcomposer:description=A pure, generic microformats2 parser — makes
> > HTML as easy to consume as a${Newline}JSON API
> > phpcomposer:Debian-require=php-cli, php-common
> > phpcomposer:Debian-require-dev=phpunit (>= 3.7), phpunit (<< 3.8~~)
> > phpcomposer:Debian-suggest=php-barnabywalters-mf-cleaner
> >
> > The above commands result in:
> >
> > # grep -s -v phpcomposer:name debian/php-mf2.substvars
> > Binary file debian/php-mf2.substvars matches
> 
> It looks like grep is taking php-mf2.substvars as a binary file. Can
> you attach php-mf2.substvars?

You are very right! At that point, it is:

# cat debian/php-mf2.substvars 
phpcomposer:name=mf2/mf2
phpcomposer:description=A pure, generic microformats2 parser — makes
HTML as easy to consume as a${Newline}JSON API

So I think it's the long dash?

> It looks like your debhelper version is missing:
> https://anonscm.debian.org/git/debhelper/debhelper.git/commit/Debian/Debhelper/Dh_Lib.pm?id=9ca73a0a80fcfc93c1f47e41c61318b038f4e2da

Yep, backporting that fixed it for me!

Thank you!
-Nish

-- 
Nishanth Aravamudan
Ubuntu Server
Canonical Ltd