[Pkg-postgresql-private] Going to fix #209171

[Oliver Elphick]

On Wed, 2003-10-15 at 22:10, Martin Pitt wrote:
> Hi!
> 
> I will fix #209171 ("postgres 7.4.3-2 doesn't install on fresh sid").
> It is an obvious bug and not hard to tackle with, but I'm unsure about
> the following:
> 
> The preinst saves the current state (pg_dumpall and config files) even
> if no current database is installed. Is there a reason why the
> binaries are saved anyway? Currently I don't see the reason why this
> is necessary.

The way things currently work, it should only save in those
circumstances if it finds existing programs where the package will put
its files and no package is installed.  This is not likely, but could
result from someone's private decision not to use /usr/local in a
self-build.

> BTW, what shall we do about #203519 (the '' in ' comments thingy)? The
> way Oliver describes the problem sounds like wontfix.

To fix this would require a major change to CREATE FUNCTION, because it
doesn't parse the function code until the function is run.  So it
doesn't know anything about comments.  Since it is possible to define
your own language, it is unreasonable to expect CREATE FUNCTION to know
about the syntax of the arbitrary code specified by AS 'xxx'.

I should definitely mark it wontfix.  You may care to pass it upstream
if you wish; I didn't think it worthwhile.

-- 
Oliver Elphick                                Oliver.Elphick@lfix.co.uk
Isle of Wight, UK                             http://www.lfix.co.uk/oliver
GPG: 1024D/3E1D0C1C: CA12 09E0 E8D5 8870 5839  932A 614D 4C34 3E1D 0C1C
                 ========================================
     "If ye love me, keep my commandments."       John 14:15