[Pkg-postgresql-public] /etc/postgresql/8.1/main/environment needs quotet strings

[Martin Pitt]

Hi Andreas,

Andreas Tille [2006-04-11 16:22 +0200]:
> If I need '/' in the variable string I have to do the following quoting:
> 
> 
>     R_HOME='/usr/lib/R'
> 
> It took me a while to find this out and I personally would regard
> this as a bug in parsing /etc/postgresql/8.1/main/environment.

Well, it's really the same syntax as postgresql.conf, so in particular
it's NOT shell syntax.

> and thus the quoting might be intended but I would regard it as
> unusual to quote the whole string.  If this is really needed for
> some reason the comment should definitely be enhanced.

The reason is just that p-common uses the same function for reading
'environment' and '*.conf'. I agree that it wouldn't hurt to add '/'
to the regexp for allowed characters in 'simple' values, but then
read_conf_file() would accept invalid postgresql.conf files, too.

Thus I'd rather improve the comment in the file. Could you live with
that?

Thanks, and happy Easter holidays,

Martin

-- 
Martin Pitt        http://www.piware.de
Ubuntu Developer   http://www.ubuntu.com
Debian Developer   http://www.debian.org