[Pkg-postgresql-public] Bug#736532: [postgres-xc] gtm proxy support in init script

Michael Meskes meskes at debian.org
Thu Apr 3 11:42:28 UTC 2014


On Fri, Jan 24, 2014 at 11:59:59AM -0500, Tim Sattarov wrote:
> Please find below my suggested patch for init script to handle that
> additional component of postgres-xc:

Thanks for the patch, but please for the next time, do not inline it like this. There a linebreaks in there which makes it unapplicable.

> --- /etc/init.d/postgres-xc     2013-08-20 07:29:54.000000000 -0400
> +++ ./postgres-xc       2014-01-24 11:37:20.185485456 -0500

Also, please always send patches against the source files, not the installed version. They may be different.

> @@ -40,7 +44,7 @@
>          postgres)
>              pidfile=postmaster.pid
>              confport=$(grep -si '^port *=' $PGXC_DATA/$2/postgresql.conf |
> -               cut -f2 -d= | sed -e 's/#.*$//' -e 's/ //g')
> +                cut -f2 -d= | sed -e 's/#.*$//' -e 's/ //g')
>              port=${confport:=5432}
> 
>              # wait for server to come up, but no more than 10 seconds

What is changed here? Only a blank?

Patch will be in the next release.

Michael
-- 
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Michael at BorussiaFan dot De, Meskes at (Debian|Postgresql) dot Org
Jabber: michael.meskes at gmail dot com
VfL Borussia! Força Barça! Go SF 49ers! Use Debian GNU/Linux, PostgreSQL



More information about the Pkg-postgresql-public mailing list