[Pkg-postgresql-public] Bug#742493: Bug#742493: Bug#742493: pgmemcache segfaults with libmemcached11

[Christoph Berg]

Re: Hannu Valtonen 2014-05-08 <536BAD38.7090803 at ohmu.fi>
> http://bazaar.launchpad.net/~tangent-trunk/libmemcached/1.0/revision/1121.1.13
> 
> You're misreading the change. Basically libmemcached stopped using the
> custom memory allocator and changed to using malloc unconditionally,
> breaking backwards compatibility. Before the change it used the custom
> memory allocator which in our case was palloc.

Ok.

Still, shouldn't the other pfree(list) there be changed as well?

> >--- pgmemcache.orig/pgmemcache.c	2014-05-08 15:25:30.260692035 +0200
> >+++ pgmemcache/pgmemcache.c	2014-05-08 15:27:13.164195600 +0200
> >@@ -818,10 +818,10 @@ static memcached_return_t server_stat_fu
> >      {
> >        char *value = memcached_stat_get_value(ptr, &stat, *stat_ptr, &rc);
> >        appendStringInfo(context, "%s: %s\n", *stat_ptr, value);
> >-      libmc_stat_free(value);
> >+      free(value);
> >      }
> >-  pfree(list);
> >+  free(list);
> >    return MEMCACHED_SUCCESS;
> >  }

Christoph
-- 
cb at df7cb.de | http://www.df7cb.de/