[Pkg-postgresql-public] Bug#777524: skytools3: Test regression with PostgreSQL 9.4.1 due to invalid \set ECHO
Martin Pitt
mpitt at debian.org
Mon Feb 9 08:32:05 UTC 2015
Package: skytools3
Version: 3.2-2
Tags: patch upstream
Forwarded: http://pgfoundry.org/tracker/index.php?func=detail&aid=1011470&group_id=1000206&atid=818
User: ubuntu-devel at lists.ubuntu.com
Usertags: origin-ubuntu ubuntu-patch vivid
User: autopkgtest-devel at lists.alioth.debian.org
Usertags: autopkgtest
Hello,
as you see on http://ci.debian.net/packages/s/skytools3/unstable/amd64/
this package started to fail its tests with PostgreSQL 9.4.1. That
version now writes an error message on invalid values of \set ECHO;
this error message appears in the test output and thus causes a
mismatch with the expected output:
| *** /tmp/adt-run.fCxzWm/build.sgr/skytools3-3.2/sql/londiste/expected/init_ext_1.out 2013-07-29 08:14:55.000000000 +0000
| --- /tmp/adt-run.fCxzWm/build.sgr/skytools3-3.2/sql/londiste/results/init_ext.out 2015-02-08 12:39:46.177125312 +0000
| ***************
| *** 1,4 ****
| --- 1,5 ----
| \set ECHO off
| + unrecognized value "off" for "ECHO"; assuming "none"
| upgrade_schema
| ----------------
| 2
debdiff attached. I also forwarded the patch upstream to pgfoundry.
Thanks for considering,
Martin
--
Martin Pitt | http://www.piware.de
Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org)
-------------- next part --------------
diff -Nru skytools3-3.2/debian/changelog skytools3-3.2/debian/changelog
--- skytools3-3.2/debian/changelog 2014-08-13 23:57:46.000000000 +0200
+++ skytools3-3.2/debian/changelog 2015-02-09 09:17:18.000000000 +0100
@@ -1,3 +1,10 @@
+skytools3 (3.2-2ubuntu1) vivid; urgency=medium
+
+ * Add tests-invalid-echo.patch: Fix invalid "off" value for \set ECHO to
+ "none". Fixes test regression with PostgreSQL 9.4.1.
+
+ -- Martin Pitt <martin.pitt at ubuntu.com> Mon, 09 Feb 2015 09:16:15 +0100
+
skytools3 (3.2-2) unstable; urgency=medium
* Remove /var/{log,run}/skytools on purge. Spotted by piuparts.
diff -Nru skytools3-3.2/debian/patches/series skytools3-3.2/debian/patches/series
--- skytools3-3.2/debian/patches/series 2014-07-28 00:19:59.000000000 +0200
+++ skytools3-3.2/debian/patches/series 2015-02-09 09:11:44.000000000 +0100
@@ -1 +1,2 @@
a0f3c0e169ad19ab8486bbb95855132550f905c2
+tests-invalid-echo.patch
diff -Nru skytools3-3.2/debian/patches/tests-invalid-echo.patch skytools3-3.2/debian/patches/tests-invalid-echo.patch
--- skytools3-3.2/debian/patches/tests-invalid-echo.patch 1970-01-01 01:00:00.000000000 +0100
+++ skytools3-3.2/debian/patches/tests-invalid-echo.patch 2015-02-09 09:26:18.000000000 +0100
@@ -0,0 +1,191 @@
+Description: Fix invalid "off" value for \set ECHO to "none". Fixes test regression with PostgreSQL 9.4.1.
+Author: Martin Pitt <martin.pitt at ubuntu.com>
+Forwarded: http://pgfoundry.org/tracker/index.php?func=detail&aid=1011470&group_id=1000206&atid=818
+
+Index: skytools3-3.2/sql/londiste/sql/init_ext.sql
+===================================================================
+--- skytools3-3.2.orig/sql/londiste/sql/init_ext.sql
++++ skytools3-3.2/sql/londiste/sql/init_ext.sql
+@@ -1,4 +1,4 @@
+-\set ECHO off
++\set ECHO none
+
+ set log_error_verbosity = 'terse';
+ set client_min_messages = 'fatal';
+Index: skytools3-3.2/sql/londiste/sql/init_noext.sql
+===================================================================
+--- skytools3-3.2.orig/sql/londiste/sql/init_noext.sql
++++ skytools3-3.2/sql/londiste/sql/init_noext.sql
+@@ -1,4 +1,4 @@
+-\set ECHO off
++\set ECHO none
+
+ set log_error_verbosity = 'terse';
+ set client_min_messages = 'fatal';
+Index: skytools3-3.2/sql/londiste/sql/londiste_install.sql
+===================================================================
+--- skytools3-3.2.orig/sql/londiste/sql/londiste_install.sql
++++ skytools3-3.2/sql/londiste/sql/londiste_install.sql
+@@ -1,4 +1,4 @@
+-\set ECHO off
++\set ECHO none
+
+ set log_error_verbosity = 'terse';
+ set client_min_messages = 'fatal';
+Index: skytools3-3.2/sql/londiste/sql/londiste_merge.sql
+===================================================================
+--- skytools3-3.2.orig/sql/londiste/sql/londiste_merge.sql
++++ skytools3-3.2/sql/londiste/sql/londiste_merge.sql
+@@ -70,7 +70,7 @@ select * from londiste.get_table_list('c
+
+ select * from londiste.global_add_table('part3_set', 'tblmerge');
+
+-\set ECHO off
++\set ECHO none
+
+ create table states ( state text );
+ insert into states values ('in-copy');
+Index: skytools3-3.2/sql/pgq/sql/pgq_perms.sql
+===================================================================
+--- skytools3-3.2.orig/sql/pgq/sql/pgq_perms.sql
++++ skytools3-3.2/sql/pgq/sql/pgq_perms.sql
+@@ -1,4 +1,4 @@
+-\set ECHO off
++\set ECHO none
+ \set VERBOSITY 'terse'
+ set client_min_messages = 'warning';
+
+Index: skytools3-3.2/sql/pgq_ext/sql/init_ext.sql
+===================================================================
+--- skytools3-3.2.orig/sql/pgq_ext/sql/init_ext.sql
++++ skytools3-3.2/sql/pgq_ext/sql/init_ext.sql
+@@ -1,5 +1,5 @@
+
+-\set ECHO off
++\set ECHO none
+ \i structure/install.sql
+ \set ECHO all
+ create extension pgq_ext from 'unpackaged';
+Index: skytools3-3.2/sql/pgq_ext/sql/init_noext.sql
+===================================================================
+--- skytools3-3.2.orig/sql/pgq_ext/sql/init_noext.sql
++++ skytools3-3.2/sql/pgq_ext/sql/init_noext.sql
+@@ -1,3 +1,3 @@
+-\set ECHO off
++\set ECHO none
+ \i structure/install.sql
+
+Index: skytools3-3.2/sql/pgq_ext/sql/test_upgrade.sql
+===================================================================
+--- skytools3-3.2.orig/sql/pgq_ext/sql/test_upgrade.sql
++++ skytools3-3.2/sql/pgq_ext/sql/test_upgrade.sql
+@@ -1,5 +1,5 @@
+
+-\set ECHO off
++\set ECHO none
+
+ set log_error_verbosity = 'terse';
+ set client_min_messages = 'fatal';
+Index: skytools3-3.2/sql/londiste/expected/init_ext.out
+===================================================================
+--- skytools3-3.2.orig/sql/londiste/expected/init_ext.out
++++ skytools3-3.2/sql/londiste/expected/init_ext.out
+@@ -1,4 +1,4 @@
+-\set ECHO off
++\set ECHO none
+ upgrade_schema
+ ----------------
+ 0
+Index: skytools3-3.2/sql/londiste/expected/init_ext_1.out
+===================================================================
+--- skytools3-3.2.orig/sql/londiste/expected/init_ext_1.out
++++ skytools3-3.2/sql/londiste/expected/init_ext_1.out
+@@ -1,4 +1,4 @@
+-\set ECHO off
++\set ECHO none
+ upgrade_schema
+ ----------------
+ 2
+Index: skytools3-3.2/sql/londiste/expected/init_noext.out
+===================================================================
+--- skytools3-3.2.orig/sql/londiste/expected/init_noext.out
++++ skytools3-3.2/sql/londiste/expected/init_noext.out
+@@ -1,4 +1,4 @@
+-\set ECHO off
++\set ECHO none
+ upgrade_schema
+ ----------------
+ 0
+Index: skytools3-3.2/sql/londiste/expected/init_noext_1.out
+===================================================================
+--- skytools3-3.2.orig/sql/londiste/expected/init_noext_1.out
++++ skytools3-3.2/sql/londiste/expected/init_noext_1.out
+@@ -1,4 +1,4 @@
+-\set ECHO off
++\set ECHO none
+ upgrade_schema
+ ----------------
+ 0
+Index: skytools3-3.2/sql/londiste/expected/londiste_install.out
+===================================================================
+--- skytools3-3.2.orig/sql/londiste/expected/londiste_install.out
++++ skytools3-3.2/sql/londiste/expected/londiste_install.out
+@@ -1,4 +1,4 @@
+-\set ECHO off
++\set ECHO none
+ upgrade_schema
+ ----------------
+ 0
+Index: skytools3-3.2/sql/londiste/expected/londiste_merge.out
+===================================================================
+--- skytools3-3.2.orig/sql/londiste/expected/londiste_merge.out
++++ skytools3-3.2/sql/londiste/expected/londiste_merge.out
+@@ -253,7 +253,7 @@ select * from londiste.global_add_table(
+ 200 | Table added: tblmerge
+ (1 row)
+
+-\set ECHO off
++\set ECHO none
+ select * from testmatrix();
+ p1s | p2s | p3s | p1r | p2r | p3r
+ --------------+--------------+--------------+-------------+-------------+-------------
+Index: skytools3-3.2/sql/pgq/expected/pgq_perms.out
+===================================================================
+--- skytools3-3.2.orig/sql/pgq/expected/pgq_perms.out
++++ skytools3-3.2/sql/pgq/expected/pgq_perms.out
+@@ -1,4 +1,4 @@
+-\set ECHO off
++\set ECHO none
+ drop role if exists pgq_test_producer;
+ drop role if exists pgq_test_consumer;
+ drop role if exists pgq_test_admin;
+Index: skytools3-3.2/sql/pgq_ext/expected/init_ext.out
+===================================================================
+--- skytools3-3.2.orig/sql/pgq_ext/expected/init_ext.out
++++ skytools3-3.2/sql/pgq_ext/expected/init_ext.out
+@@ -1,4 +1,4 @@
+-\set ECHO off
++\set ECHO none
+ upgrade_schema
+ ----------------
+ 4
+Index: skytools3-3.2/sql/pgq_ext/expected/init_noext.out
+===================================================================
+--- skytools3-3.2.orig/sql/pgq_ext/expected/init_noext.out
++++ skytools3-3.2/sql/pgq_ext/expected/init_noext.out
+@@ -1,4 +1,4 @@
+-\set ECHO off
++\set ECHO none
+ upgrade_schema
+ ----------------
+ 4
+Index: skytools3-3.2/sql/pgq_ext/expected/test_upgrade.out
+===================================================================
+--- skytools3-3.2.orig/sql/pgq_ext/expected/test_upgrade.out
++++ skytools3-3.2/sql/pgq_ext/expected/test_upgrade.out
+@@ -1,4 +1,4 @@
+-\set ECHO off
++\set ECHO none
+ upgrade_schema
+ ----------------
+ 8
More information about the Pkg-postgresql-public
mailing list