[Pkg-postgresql-public] [pgsql-pkg-debian] Debian packaging of the q3c and pgsphere extensions

[Ole Streicher]

Hi Christoph,

On 06.08.2017 19:51, Christoph Berg wrote:
> Re: Ole Streicher 2017-08-04 <1c160beb-9ece-000c-628f-77a6f19dbe5c at debian.org>
>> I have polished both packages, with the repository still in the
>> debian-science section (but I will move them to pkg-postgresql as soon
>> as I become a member). They look fine to me now (except tests; see
>> below), but could you have a look there?
> 
> Alioth says you are a pkg-postgresql member.

Yes, it works now, and both package repositories are moved (with
symlinks for some time).

> ... and a minimal debian/tests/control file. (See pg_buildext(1))

Ah, so there are no built time checks possible "just" CI test, right?

> A real problem is that the Makefile doesn't install the
> scripts/q3c--1.5.0.sql file because of its use of $(wildcard) - you'll
> need to replace that with a static list of files to install, or move
> from "pg_buildext build/install" to "pg_buildext loop".

Fixed.

> The testsuite seems to almost work except for one diff here:
> 
> diff results/version.out expected/version.expected
> 3c3
> <  f
> ---
>>  t

The tests worked for me, so I didn't change this.

> The actual debian/tests/installcheck file could be something like:
> 
> #!/bin/sh
> for v in $(pg_buildext supported-versions); do
>   LC_ALL=C pg_virtualenv -v $v make test
> done

Thanks for you help! Everything seems to work now, so I uploaded q3c:

https://ftp-master.debian.org/new/postgresql-q3c_1.5.0-1.html

For pgsphere, I had less success; the tests fail currently. For me
(being still a strawmen), this looks like an upstream problem, so I am
hoping for a response from there. If you like, you can however have a
look as well; just to double-check that it is not a packaging problem:

https://anonscm.debian.org/cgit/pkg-postgresql/pgsphere.git/

Best

Ole