[Pkg-postgresql-public] Bug#856437: postgresql-plproxy: autopkgtest depends on newpid which fails to install LXD runners

[Nishanth Aravamudan]

Package: postgresql-plproxy
Version: 2.7-1
Severity: normal
Tags: patch
User: ubuntu-devel at lists.ubuntu.com
Usertags: origin-ubuntu zesty ubuntu-patch

Dear Maintainer,

In Ubuntu, the attached patch was applied to achieve the following:

  * d/t/control: the newpid package fails to install in LXD
    environments (relies on fs capabilities which are disallowed by the
    kernel in user namespaces), so use unshare instead.

Thanks for considering the patch.

*** /tmp/tmp9Ftaz0/postgresql-plproxy_2.7-1ubuntu2.debdiff
diff -Nru postgresql-plproxy-2.7/debian/tests/control postgresql-plproxy-2.7/debian/tests/control
--- postgresql-plproxy-2.7/debian/tests/control	2017-02-28 10:19:53.000000000 -0800
+++ postgresql-plproxy-2.7/debian/tests/control	2017-02-28 16:28:57.000000000 -0800
@@ -1,3 +1,3 @@
 Tests: installcheck
-Depends: @, postgresql-server-dev-all, newpid
+Depends: @, postgresql-server-dev-all, util-linux
 Restrictions: allow-stderr needs-root
diff -Nru postgresql-plproxy-2.7/debian/tests/installcheck postgresql-plproxy-2.7/debian/tests/installcheck
--- postgresql-plproxy-2.7/debian/tests/installcheck	2017-02-28 10:19:53.000000000 -0800
+++ postgresql-plproxy-2.7/debian/tests/installcheck	2017-02-28 16:28:57.000000000 -0800
@@ -32,7 +32,7 @@
 	if ! chmod o+w $AUTOPKGTEST_TMP && \
 		PG_CLUSTER_CONF_ROOT=$AUTOPKGTEST_TMP \
 		PG_CONFIG=/usr/lib/postgresql/$v/bin/pg_config \
-		newnet pg_virtualenv -c "-p 5432 --locale C -s $AUTOPKGTEST_TMP" -i '--auth trust' -v $v \
+		unshare -inu pg_virtualenv -c "-p 5432 --locale C -s $AUTOPKGTEST_TMP" -i '--auth trust' -v $v \
 		make -f $PWD/Makefile installcheck; then \
 			head -n 500 regression.diffs
 			exit 1


-- System Information:
Debian Release: stretch/sid
  APT prefers zesty
  APT policy: (500, 'zesty')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.10.0-8-generic (SMP w/4 CPU cores)
Locale: LANG=en_AU.UTF-8, LC_CTYPE=en_AU.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

-- 
Nishanth Aravamudan
Ubuntu Server
Canonical Ltd