[Pkg-postgresql-public] Debian "postgresql-common" config check issue with pg10
myon at debian.org
Mon May 8 17:50:50 UTC 2017
Re: Fabien COELHO 2017-05-08 <alpine.DEB.2.20.1705081730030.3983 at lancre>
> Thus I naïvely added:
> password_encryption = scram-sha-256
Hmm. Naïvely I would have assumed this would be missing quotes :)
> The result is:
> Error: Invalid line 88 in /etc/postgresql/10/main/postgresql.conf:
> »password_encryption = scram-sha-256«
> However, it works if I put 'scram-sha-256' (with simple quotes).
> The underlying issue is that the '-' character breaks the config checker,
> ISTM that the simple value regex in function "read_conf_file" in module
> "PgCommon.pm" should be extended to allow more chars in unquoted strings, to
> be consistent with lexer definitions in "src/backend/utils/misc/guc-file.l".
I've relaxed the regexps there. It's still not exactly what the PG
parser accepts, but I think it's a superset now, so we should be safe.
> In passing, I would like to point out that the French quotation chevrons
> (guillemets) used on the wrong sides and without spacing is probably eye
> watering pain to any French reader, maybe like using ß in place of B in a
> text. Also utf8 chars might not work properly under some terminal encodings.
> Maybe using simple ascii ">>" and "<<" for the messages would also be more
I think »« are used the other way round in German vs. French, that's
probably why it was like that ;). Anyway, we are not quoting output in
most of the error() calls, so I've simply dropped the quotes.
Thanks for spotting and reporting!
More information about the Pkg-postgresql-public