[Pkg-protobuf-devel] Bug#835337: protobuf patch with -Wno-error=misleading-indentation needs gcc 6

Wed Aug 24 15:46:22 UTC 2016

On Wed, Aug 24, 2016 at 04:46:47PM +0200, Sebastiaan Couwenberg wrote:
> Control: tags -1 moreinfo
> 
> Hi Florian,
> 
> On Wed, 24 Aug 2016 16:20:22 +0200 Florian Lohoff <f at zz.de> wrote:
> >the patch enabling the -Wno-error=misleading-indentation should
> >also cause a build-dependency for newer gcc or better be only applied
> >when building with gcc 6+
> >
> >Jessies gcc 4.9 barfs at it ...
> 
> Barfs at what?
> 
> Please provide a more complete buildlog.
> 
> Or simply disable the patch for your unofficial backport.

Thats exactly what i did to get it build ... My impression is
that when using special gcc options one should have a build-dep
on that version ...

flo at p3:/tmp/protobuf-3.0.0$ dpkg-buildpackage -rfakeroot -b
dpkg-buildpackage: source package protobuf
dpkg-buildpackage: source version 3.0.0-3
dpkg-buildpackage: source distribution unstable
dpkg-buildpackage: source changed by Dmitry Smirnov <onlyjob at debian.org>
dpkg-buildpackage: host architecture amd64
 dpkg-source --before-build protobuf-3.0.0
 fakeroot debian/rules clean
dh clean --with autoreconf,python2 --parallel
   dh_testdir -O--parallel
   debian/rules override_dh_auto_clean-arch
make[1]: Entering directory '/tmp/protobuf-3.0.0'

[ ... ]

g++ -DHAVE_CONFIG_H -I. -I..  -I./../gmock/include -I./../gmock/gtest/include -D_FORTIFY_SOURCE=2 -pthread -DHAVE_PTHREAD=1 -DHAVE_ZLIB=1 -Wall -Wno-sign-compare -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -c -o google/protobuf/protobuf_lite_arena_test-unittest_lite.pb.o `test -f 'google/protobuf/unittest_lite.pb.cc' || echo './'`google/protobuf/unittest_lite.pb.cc
g++ -DHAVE_CONFIG_H -I. -I..  -I./../gmock/include -I./../gmock/gtest/include -D_FORTIFY_SOURCE=2 -pthread -DHAVE_PTHREAD=1 -DHAVE_ZLIB=1 -Wall -Wno-sign-compare -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -c -o google/protobuf/protobuf_lite_arena_test-unittest_no_arena_lite.pb.o `test -f 'google/protobuf/unittest_no_arena_lite.pb.cc' || echo './'`google/protobuf/unittest_no_arena_lite.pb.cc
g++ -DHAVE_CONFIG_H -I. -I..  -I./../gmock/include -I./../gmock/gtest/include -D_FORTIFY_SOURCE=2 -pthread -DHAVE_PTHREAD=1 -DHAVE_ZLIB=1 -Wall -Wno-sign-compare -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -c -o google/protobuf/protobuf_lite_arena_test-unittest_import_lite.pb.o `test -f 'google/protobuf/unittest_import_lite.pb.cc' || echo './'`google/protobuf/unittest_import_lite.pb.cc
g++ -DHAVE_CONFIG_H -I. -I..  -I./../gmock/include -I./../gmock/gtest/include -D_FORTIFY_SOURCE=2 -pthread -DHAVE_PTHREAD=1 -DHAVE_ZLIB=1 -Wall -Wno-sign-compare -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -c -o google/protobuf/protobuf_lite_arena_test-unittest_import_public_lite.pb.o `test -f 'google/protobuf/unittest_import_public_lite.pb.cc' || echo './'`google/protobuf/unittest_import_public_lite.pb.cc
/bin/bash ../libtool  --tag=CXX   --mode=link g++ -pthread -DHAVE_PTHREAD=1 -DHAVE_ZLIB=1 -Wall -Wno-sign-compare -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -pthread -Wl,-z,relro -o protobuf-lite-arena-test google/protobuf/protobuf_lite_arena_test-lite_arena_unittest.o google/protobuf/protobuf_lite_arena_test-arena_test_util.o google/protobuf/protobuf_lite_arena_test-map_lite_test_util.o google/protobuf/protobuf_lite_arena_test-test_util_lite.o google/protobuf/protobuf_lite_arena_test-map_lite_unittest.pb.o google/protobuf/protobuf_lite_arena_test-unittest_lite.pb.o google/protobuf/protobuf_lite_arena_test-unittest_no_arena_lite.pb.o google/protobuf/protobuf_lite_arena_test-unittest_import_lite.pb.o google/protobuf/protobuf_lite_arena_test-unittest_import_public_lite.pb.o -lpthread libprotobuf-lite.la ../gmock/gtest/lib/libgtest.la ../gmock/lib/libgmock.la ../gmock/lib/libgmock_main.la -lz 
libtool: link: g++ -pthread -DHAVE_PTHREAD=1 -DHAVE_ZLIB=1 -Wall -Wno-sign-compare -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -pthread -Wl,-z -Wl,relro -o .libs/protobuf-lite-arena-test google/protobuf/protobuf_lite_arena_test-lite_arena_unittest.o google/protobuf/protobuf_lite_arena_test-arena_test_util.o google/protobuf/protobuf_lite_arena_test-map_lite_test_util.o google/protobuf/protobuf_lite_arena_test-test_util_lite.o google/protobuf/protobuf_lite_arena_test-map_lite_unittest.pb.o google/protobuf/protobuf_lite_arena_test-unittest_lite.pb.o google/protobuf/protobuf_lite_arena_test-unittest_no_arena_lite.pb.o google/protobuf/protobuf_lite_arena_test-unittest_import_lite.pb.o google/protobuf/protobuf_lite_arena_test-unittest_import_public_lite.pb.o  -lpthread ./.libs/libprotobuf-lite.so ../gmock/gtest/lib/.libs/libgtest.so ../gmock/lib/.libs/libgmock.so ../gmock/lib/.libs/libgmock_main.so -lz -pthread
echo "// Generated from Makefile.am" > no_warning_test.cc
for FILE in google/protobuf/stubs/atomic_sequence_num.h google/protobuf/stubs/atomicops.h google/protobuf/stubs/atomicops_internals_power.h google/protobuf/stubs/atomicops_internals_ppc_gcc.h google/protobuf/stubs/atomicops_internals_arm64_gcc.h google/protobuf/stubs/atomicops_internals_arm_gcc.h google/protobuf/stubs/atomicops_internals_arm_qnx.h google/protobuf/stubs/atomicops_internals_atomicword_compat.h google/protobuf/stubs/atomicops_internals_generic_gcc.h google/protobuf/stubs/atomicops_internals_macosx.h google/protobuf/stubs/atomicops_internals_mips_gcc.h google/protobuf/stubs/atomicops_internals_pnacl.h google/protobuf/stubs/atomicops_internals_solaris.h google/protobuf/stubs/atomicops_internals_tsan.h google/protobuf/stubs/atomicops_internals_x86_gcc.h google/protobuf/stubs/atomicops_internals_x86_msvc.h google/protobuf/stubs/callback.h google/protobuf/stubs/bytestream.h google/protobuf/stubs/casts.h google/protobuf/stubs/common.h google/protobuf/stubs/fastmem.h google/protobuf/stubs/hash.h google/protobuf/stubs/logging.h google/protobuf/stubs/macros.h google/protobuf/stubs/mutex.h google/protobuf/stubs/once.h google/protobuf/stubs/platform_macros.h google/protobuf/stubs/port.h google/protobuf/stubs/scoped_ptr.h google/protobuf/stubs/shared_ptr.h google/protobuf/stubs/singleton.h google/protobuf/stubs/status.h google/protobuf/stubs/stl_util.h google/protobuf/stubs/stringpiece.h google/protobuf/stubs/template_util.h google/protobuf/stubs/type_traits.h google/protobuf/any.pb.h google/protobuf/api.pb.h google/protobuf/any.h google/protobuf/arena.h google/protobuf/arenastring.h google/protobuf/descriptor_database.h google/protobuf/descriptor.h google/protobuf/descriptor.pb.h google/protobuf/duration.pb.h google/protobuf/dynamic_message.h google/protobuf/empty.pb.h google/protobuf/extension_set.h google/protobuf/field_mask.pb.h google/protobuf/generated_enum_reflection.h google/protobuf/generated_enum_util.h google/protobuf/generated_message_reflection.h google/protobuf/generated_message_util.h google/protobuf/map_entry.h google/protobuf/map_entry_lite.h google/protobuf/map_field.h google/protobuf/map_field_inl.h google/protobuf/map_field_lite.h google/protobuf/map.h google/protobuf/map_type_handler.h google/protobuf/message.h google/protobuf/message_lite.h google/protobuf/metadata.h google/protobuf/reflection.h google/protobuf/reflection_ops.h google/protobuf/repeated_field.h google/protobuf/service.h google/protobuf/source_context.pb.h google/protobuf/struct.pb.h google/protobuf/text_format.h google/protobuf/timestamp.pb.h google/protobuf/type.pb.h google/protobuf/unknown_field_set.h google/protobuf/wire_format.h google/protobuf/wire_format_lite.h google/protobuf/wire_format_lite_inl.h google/protobuf/wrappers.pb.h google/protobuf/io/coded_stream.h google/protobuf/io/gzip_stream.h google/protobuf/io/printer.h google/protobuf/io/strtod.h google/protobuf/io/tokenizer.h google/protobuf/io/zero_copy_stream.h google/protobuf/io/zero_copy_stream_impl.h google/protobuf/io/zero_copy_stream_impl_lite.h google/protobuf/compiler/code_generator.h google/protobuf/compiler/command_line_interface.h google/protobuf/compiler/importer.h google/protobuf/compiler/parser.h google/protobuf/compiler/plugin.h google/protobuf/compiler/plugin.pb.h google/protobuf/compiler/cpp/cpp_generator.h google/protobuf/compiler/csharp/csharp_generator.h google/protobuf/compiler/csharp/csharp_names.h google/protobuf/compiler/java/java_generator.h google/protobuf/compiler/java/java_names.h google/protobuf/compiler/javanano/javanano_generator.h google/protobuf/compiler/js/js_generator.h google/protobuf/compiler/objectivec/objectivec_generator.h google/protobuf/compiler/objectivec/objectivec_helpers.h google/protobuf/compiler/python/python_generator.h google/protobuf/compiler/ruby/ruby_generator.h google/protobuf/util/type_resolver.h google/protobuf/util/field_comparator.h google/protobuf/util/field_mask_util.h google/protobuf/util/json_util.h google/protobuf/util/time_util.h google/protobuf/util/type_resolver_util.h google/protobuf/util/message_differencer.h; do \
  if ! echo ${FILE} | grep "atomicops"; then \
    echo "#include <${FILE}>" >> no_warning_test.cc; \
  fi \
done
google/protobuf/stubs/atomicops.h
google/protobuf/stubs/atomicops_internals_power.h
google/protobuf/stubs/atomicops_internals_ppc_gcc.h
google/protobuf/stubs/atomicops_internals_arm64_gcc.h
google/protobuf/stubs/atomicops_internals_arm_gcc.h
google/protobuf/stubs/atomicops_internals_arm_qnx.h
google/protobuf/stubs/atomicops_internals_atomicword_compat.h
google/protobuf/stubs/atomicops_internals_generic_gcc.h
google/protobuf/stubs/atomicops_internals_macosx.h
google/protobuf/stubs/atomicops_internals_mips_gcc.h
google/protobuf/stubs/atomicops_internals_pnacl.h
google/protobuf/stubs/atomicops_internals_solaris.h
google/protobuf/stubs/atomicops_internals_tsan.h
google/protobuf/stubs/atomicops_internals_x86_gcc.h
google/protobuf/stubs/atomicops_internals_x86_msvc.h
echo "#include <gtest/gtest.h>" >> no_warning_test.cc
echo "TEST(NoWarningTest, Empty) {}" >> no_warning_test.cc
g++ -DHAVE_CONFIG_H -I. -I..  -I./../gmock/gtest/include -D_FORTIFY_SOURCE=2 -pthread -DHAVE_PTHREAD=1 -DHAVE_ZLIB=1 -Wall -Werror -Wno-error=misleading-indentation -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -c -o no_warning_test-no_warning_test.o `test -f 'no_warning_test.cc' || echo './'`no_warning_test.cc
cc1plus: error: -Werror=misleading-indentation: no option -Wmisleading-indentation
Makefile:3875: recipe for target 'no_warning_test-no_warning_test.o' failed
make[5]: *** [no_warning_test-no_warning_test.o] Error 1
make[5]: Leaving directory '/tmp/protobuf-3.0.0/src'
Makefile:7474: recipe for target 'check-am' failed
make[4]: *** [check-am] Error 2
make[4]: Leaving directory '/tmp/protobuf-3.0.0/src'
Makefile:7477: recipe for target 'check' failed
make[3]: *** [check] Error 2
make[3]: Leaving directory '/tmp/protobuf-3.0.0/src'
Makefile:1248: recipe for target 'check-recursive' failed
make[2]: *** [check-recursive] Error 1
make[2]: Leaving directory '/tmp/protobuf-3.0.0'
dh_auto_test: make -j1 check returned exit code 2
debian/rules:44: recipe for target 'override_dh_auto_test-arch' failed
make[1]: *** [override_dh_auto_test-arch] Error 2
make[1]: Leaving directory '/tmp/protobuf-3.0.0'
debian/rules:9: recipe for target 'build' failed
make: *** [build] Error 2
dpkg-buildpackage: error: debian/rules build gave error exit status 2

Flo
-- 
Florian Lohoff                                                 f at zz.de
             UTF-8 Test: The 🐈 ran after a 🐁, but the 🐁 ran away
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 828 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-protobuf-devel/attachments/20160824/3a3e5d99/attachment.sig>