[Pkg-protobuf-devel] Bug#835514: libprotobuf-java: junit and easymock dependencies should only be required for tests

[Sebastiaan Couwenberg]

On Fri, 26 Aug 2016 14:36:00 +0200 Markus Koschany wrote:
> thanks for fixing #835358 so quickly. Unfortunately there is another
> issue with the pom.xml file now. java/core/pom.xml lists junit and
> easymock artifacts as dependencies but libprotobuf-java does not
> depend on these packages. This causes build failures like [1].
>
> libprotobuf-java should either depend on the respective packages or
> change the scope to test again as in earlier versions. I think the
> latter solution is preferable because junit and easymock are only
> needed for tests. If you take a look at version 2.6.1, you will see
> that scope test was used before. [2] I don't know why they changed this
> but it looks like an upstream bug to me.
>
> I'm attaching a patch that resolves the issue and restores the old
> behavior again.

I agree with Markus' assessment that restoring the test scope is 
preferable. It looks like the restructuring in [0] was overly ambitious 
in removing both the version and scope properties.

[0] 
https://github.com/google/protobuf/commit/49efe9d7db877022e76375df2d4daadab98619b6

Kind Regards,

Bas

-- 
  GPG Key ID: 4096R/6750F10AE88D4AF1
Fingerprint: 8182 DE41 7056 408D 6146  50D1 6750 F10A E88D 4AF1