[MERGE] Fix _multivalued.dump() (#457929).

Adeodato Simó dato at net.com.org.es
Fri Dec 28 17:51:01 UTC 2007


Hello again.

Chasing this has made me want to rewrite deb822.py from scratch, oh
well.

Self-explanatory commit message:

  Fix _multivalued.dump() (#457929).

  Two bugs needed fixing (and it was difficult adding a test for the first
  one without fixing the second one as well):

    * When checking if a key was in _multivalued_fields, the plain key as
      returned by self.keys() was used, but .keys() does not return case
      insensitive strings (why??), so fields were never regarded as
      multivalue. Add test_bug457929_multivalued_dump_works to check for
      this.

    * For multi-line but not multi-valued fields, an extra trailing space
      was being printed. Copy code to handle this from Deb822.dump(), and
      extend test_multiline_trailing_whitespace_after_colon to exercise
      both Deb822 and _multivalued via deb822.Changes (changing the parsed
      file from a dsc to a changes file, which contains multi-line not
      multi-valued fields).

Cheers,

-- 
Adeodato Simó                                     dato at net.com.org.es
Debian Developer                                  adeodato at debian.org
 
- Denny, I could be wrong, but you might want to think about settling this.
- You're absolutely right: you could be wrong.
                -- Alan Shore and Denny Crane
-------------- next part --------------
A non-text attachment was scrubbed...
Name: bzr-mail-tCc6ss.patch
Type: text/x-diff
Size: 9478 bytes
Desc: not available
Url : http://lists.alioth.debian.org/pipermail/pkg-python-debian-discuss/attachments/20071228/35383e5e/attachment.patch 


More information about the pkg-python-debian-discuss mailing list