[PATCH] move tests outside of debian_bundle
Adeodato Simó
dato at net.com.org.es
Thu Nov 29 17:05:35 UTC 2007
* Filippo Giunchedi [Thu, 29 Nov 2007 16:39:51 +0100]:
> Hi,
> attached there's a bundle to move tests outside debian_bundle/ into tests/.
> Comments welcome as usual.
Thanks! (For the rest of the list, I asked Filippo if he minded putting
into practice the workflow I had in mind when I created python-debian,
but that wasn't around to suggest when code began to get commited.
Namely, that somebody reviews the code on the list before commiting.
Does anybody object to that?)
> +++ tests/test_deb822.py 2007-11-29 15:27:12 +0000
> +sys.path.append('../debian_bundle/')
> +
> +import deb822
This one will fail if python-debian is installed, because the installed
copy of deb822 will be used. I suggest:
sys.path.insert(0, '../debian_bundle/')
> +++ tests/test_debfile.py 2007-11-29 15:27:12 +0000
> +sys.path.append('../debian_bundle/')
> +++ tests/test_debtags.py 2007-11-29 15:27:12 +0000
> +sys.path.append('../debian_bundle/')
These could be changed as well, for consistency. With that, I think it's
ready to merge (bundle attached), though probably I'll look into giving
tests an __init__.py that can run all the tests by itself.
Cheers,
--
Adeodato Simó dato at net.com.org.es
Debian Developer adeodato at debian.org
People are more violently opposed to fur than leather because it's safer to
harass rich women than motorcycle gangs.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: move-tests-2.diff
Type: text/x-diff
Size: 7567 bytes
Desc: not available
Url : http://lists.alioth.debian.org/pipermail/pkg-python-debian-discuss/attachments/20071129/23ba4f6b/attachment.diff
More information about the pkg-python-debian-discuss
mailing list