[Pkg-ROX-devel] Bug#288439: rox: FTBFS (amd64/gcc-4.0): static declaration of 'tooltips' follows non-static declaration

[Andreas Jochens]

Package: rox
Severity: normal
Tags: patch

When building 'rox' on amd64 with gcc-4.0,
I get the following error:

toolbar.c:62: error: static declaration of 'tooltips' follows non-static declaration
main.h:15: error: previous declaration of 'tooltips' was here
toolbar.c: In function 'toolbar_help_clicked':
toolbar.c:280: warning: pointer targets in passing argument 1 of 'filer_opendir' differ in signedness
toolbar.c: In function 'option_notify':
toolbar.c:636: warning: pointer targets in passing argument 1 of 'in_list' differ in signedness
toolbar.c: In function 'read_tools':
toolbar.c:695: warning: pointer targets in return differ in signedness
toolbar.c:699: warning: pointer targets in passing argument 2 of 'g_string_append' differ in signedness
toolbar.c:704: warning: pointer targets in assignment differ in signedness
make[1]: *** [toolbar.o] Error 1
make[1]: Leaving directory `/rox-2.0.1/ROX-Filer/src'
make: *** [build-stamp] Error 2

With the attached patch 'rox' can be compiled
on amd64 using gcc-4.0.

Regards
Andreas Jochens

diff -urN ../tmp-orig/rox-2.0.1/ROX-Filer/src/toolbar.c ./ROX-Filer/src/toolbar.c
--- ../tmp-orig/rox-2.0.1/ROX-Filer/src/toolbar.c	2004-07-29 11:11:06.000000000 +0200
+++ ./ROX-Filer/src/toolbar.c	2005-01-03 19:44:40.452841040 +0100
@@ -59,8 +59,6 @@
 
 Option o_toolbar, o_toolbar_info, o_toolbar_disable;
 
-static GtkTooltips *tooltips = NULL;
-
 /* TRUE if the button presses (or released) should open a new window,
  * rather than reusing the existing one.
  */