[Pkg-ROX-devel] Bug#288439: marked as done (rox: FTBFS (amd64/gcc-4.0): static declaration of 'tooltips' follows non-static declaration)

[Debian Bug Tracking System]

Your message dated Mon, 18 Jul 2005 09:40:29 -0400
with message-id <E1DuVrB-0004Pq-00 at newraff.debian.org>
and subject line Bug#288439: fixed in rox 2.2.0-3
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

--------------------------------------
Received: (at submit) by bugs.debian.org; 3 Jan 2005 19:25:59 +0000
>From aj at andaco.de Mon Jan 03 11:25:58 2005
Return-path: <aj at andaco.de>
Received: from c173214.adsl.hansenet.de (localhost.localdomain) [213.39.173.214] 
	by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
	id 1ClXq2-0000Uo-00; Mon, 03 Jan 2005 11:25:58 -0800
Received: from aj by localhost.localdomain with local (Exim 4.34)
	id 1ClXvZ-0002mv-Be; Mon, 03 Jan 2005 20:31:41 +0100
To: Debian Bug Tracking System <submit at bugs.debian.org>
From: Andreas Jochens <aj at andaco.de>
Subject: rox: FTBFS (amd64/gcc-4.0): static declaration of 'tooltips' follows non-static declaration
Message-Id: <E1ClXvZ-0002mv-Be at localhost.localdomain>
Date: Mon, 03 Jan 2005 20:31:41 +0100
Delivered-To: submit at bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02 
	(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-8.0 required=4.0 tests=BAYES_00,HAS_PACKAGE 
	autolearn=no version=2.60-bugs.debian.org_2005_01_02
X-Spam-Level: 

Package: rox
Severity: normal
Tags: patch

When building 'rox' on amd64 with gcc-4.0,
I get the following error:

toolbar.c:62: error: static declaration of 'tooltips' follows non-static declaration
main.h:15: error: previous declaration of 'tooltips' was here
toolbar.c: In function 'toolbar_help_clicked':
toolbar.c:280: warning: pointer targets in passing argument 1 of 'filer_opendir' differ in signedness
toolbar.c: In function 'option_notify':
toolbar.c:636: warning: pointer targets in passing argument 1 of 'in_list' differ in signedness
toolbar.c: In function 'read_tools':
toolbar.c:695: warning: pointer targets in return differ in signedness
toolbar.c:699: warning: pointer targets in passing argument 2 of 'g_string_append' differ in signedness
toolbar.c:704: warning: pointer targets in assignment differ in signedness
make[1]: *** [toolbar.o] Error 1
make[1]: Leaving directory `/rox-2.0.1/ROX-Filer/src'
make: *** [build-stamp] Error 2

With the attached patch 'rox' can be compiled
on amd64 using gcc-4.0.

Regards
Andreas Jochens

diff -urN ../tmp-orig/rox-2.0.1/ROX-Filer/src/toolbar.c ./ROX-Filer/src/toolbar.c
--- ../tmp-orig/rox-2.0.1/ROX-Filer/src/toolbar.c	2004-07-29 11:11:06.000000000 +0200
+++ ./ROX-Filer/src/toolbar.c	2005-01-03 19:44:40.452841040 +0100
@@ -59,8 +59,6 @@
 
 Option o_toolbar, o_toolbar_info, o_toolbar_disable;
 
-static GtkTooltips *tooltips = NULL;
-
 /* TRUE if the button presses (or released) should open a new window,
  * rather than reusing the existing one.
  */

---------------------------------------
Received: (at 288439-close) by bugs.debian.org; 18 Jul 2005 13:53:06 +0000
>From katie at ftp-master.debian.org Mon Jul 18 06:53:06 2005
Return-path: <katie at ftp-master.debian.org>
Received: from newraff.debian.org [208.185.25.31] (mail)
	by spohr.debian.org with esmtp (Exim 3.36 1 (Debian))
	id 1DuW3O-0006R5-00; Mon, 18 Jul 2005 06:53:06 -0700
Received: from katie by newraff.debian.org with local (Exim 3.35 1 (Debian))
	id 1DuVrB-0004Pq-00; Mon, 18 Jul 2005 09:40:29 -0400
From: Francesco Paolo Lovergine <frankie at debian.org>
To: 288439-close at bugs.debian.org
X-Katie: $Revision: 1.56 $
Subject: Bug#288439: fixed in rox 2.2.0-3
Message-Id: <E1DuVrB-0004Pq-00 at newraff.debian.org>
Sender: Archive Administrator <katie at ftp-master.debian.org>
Date: Mon, 18 Jul 2005 09:40:29 -0400
Delivered-To: 288439-close at bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02 
	(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Level: 
X-Spam-Status: No, hits=-6.0 required=4.0 tests=BAYES_00,HAS_BUG_NUMBER 
	autolearn=no version=2.60-bugs.debian.org_2005_01_02

Source: rox
Source-Version: 2.2.0-3

We believe that the bug you reported is fixed in the latest version of
rox, which is due to be installed in the Debian FTP archive:

rox-filer_2.2.0-3_i386.deb
  to pool/main/r/rox/rox-filer_2.2.0-3_i386.deb
rox_2.2.0-3.diff.gz
  to pool/main/r/rox/rox_2.2.0-3.diff.gz
rox_2.2.0-3.dsc
  to pool/main/r/rox/rox_2.2.0-3.dsc



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 288439 at bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Francesco Paolo Lovergine <frankie at debian.org> (supplier of updated rox package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster at debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Mon, 18 Jul 2005 15:11:12 +0200
Source: rox
Binary: rox-filer
Architecture: source i386
Version: 2.2.0-3
Distribution: unstable
Urgency: low
Maintainer: The ROX-in-Debian Project Team <pkg-rox-devel at lists.alioth.debian.org>
Changed-By: Francesco Paolo Lovergine <frankie at debian.org>
Description: 
 rox-filer  - A simple graphical file manager for X11
Closes: 288439 299134 313825
Changes: 
 rox (2.2.0-3) unstable; urgency=low
 .
   * Added toolbar.dpatch patch to remove a double definition of a variable.
     (closes: #288439)
   * Added apprun.dpatch patch to complete transition to x-terminal-emulator alternative.
     (closes: #299134)
   * Patched de.po via dpatch.
     (closes: #313825)
   * xlibs-static-dev build-dep was superfluous: removed.
   * Policy bumped to 3.6.2, no changes.
Files: 
 2c1853fb0f44af299380c32487d12ff2 1001 x11 optional rox_2.2.0-3.dsc
 1f5b561aa561c757ceb38fcc5c67fbc6 11386 x11 optional rox_2.2.0-3.diff.gz
 3ef9e47b83e880012951503922726a34 1187958 x11 optional rox-filer_2.2.0-3_i386.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)

iD8DBQFC26t5pFNRmenyx0cRAjBjAJwJDPn3diAB3ZKEPeZLxvGcFtoxvQCfUn19
VoNP5SKpvfrp8JvXfNwnC+I=
=CT17
-----END PGP SIGNATURE-----