[Pkg-rpm-devel] Bug#887173: obs-build should depend on e2fsprogs explicitly

[Andreas Henriksson]

On Sun, Jan 14, 2018 at 08:08:26PM +0100, Helmut Grohne wrote:
> Package: obs-build
[...]
> /usr/lib/obs-build/build-vm contains mkfs.ext2, mkfs.ext3, mkfs.ext4 and tune2fs. According to file it is a ASCII text
> /usr/lib/obs-build/init_buildsystem contains chattr. According to file it is a Bourne-Again shell script, ASCII text executable
[...]

It seems both of these occurances are guarded by the CLEAN_BUILD
variable being set, which it seems to only be if you pass the
--clean command line option.

If set, there's also potential use for xfs and btrfs so their
respective packages should likely also be added at the same
potential level as e2fsprogs. Potentially it could be argued
that xfs and btrfs is less common and should thus be one level
below.

Given it doesn't seem strictly necessary for the commands to
be installed, but likely you want them if it was up to me I
might have used Recommends for e2fsprogs and either Recommends
or Suggests for xfsprogs, btrfs-tools.
If maintainers decides to be more strict and support less variantions
using Depends isn't something I'd object to either though.

Would be great to hear from maintainers on this!

Regards,
Andreas Henriksson