[Pkg-rrfw-general] Re: Unofficial Debian packages for RRFW 0.1.7 available

Marc Haber mh+pkg-rrfw-general@zugschlus.de
Sun, 15 Aug 2004 16:13:01 +0200


[Did you e-mail off-list deliberately? I think this discussion needs
to be on-list]

On Sat, Aug 14, 2004 at 06:38:33PM -0400, Jurij Smakov wrote:
> > Lintian finds some of the problems as well. Always use the very latest
> > lintian, and invoke it on the .changes file, not on the .deb. Invoking
> > lintian and linda on the .changes file will find problems with the
> > source packages as well.
> 
> Ah, thanks for the tip. Before I was only running it on .deb's.

Current linda seems to choke on rrfw, but that's a linda issue,
already reported in the BTS.

> > Executive Summary: Using debhelper autoscripts is a good idea, please
> > consider doing so.
> 
> All fixed, the automatically generated debhelper code is now inluded in
> all postinst/prerm/postrm scripts.

Thank you very much.

> > Is libapache2-parseformdata-perl needed for an installation running
> > apache 1?
> 
> Point taken, the dependency on libpapache2-parseformdata-perl moved to
> rrfw-apache2 package.

Great.

I have never seen a package done by somebody new to Debian and so
cleanly done. Congratulations. Where did you learn so much about
Debian so fast?

A few more things:

-common needs to depend on netbase, since rrfw_devdiscover fails
without /etc/services.

rrfw_devdiscover writes routers.xml to /usr/share while the file
should go to /etc. First, the local admin might want to change that
file, second, /usr should probably only have files from the
distribution, and third, /usr might be mounted r/o. Maybe the entire
xmlconfig directory should be symlinked to /etc. But actually, I think
that all files put to /usr/share/rrfw should better be in /etc.

If the daemon stop process might take more than the ten seconds it
takes on my test box (configured for a single host being queries), you
might want to steal some "progress showing" code either from squid,
zebra, or quagga's init script just to show the user that there is
still something happening.

The account name rrfw might be bad since there is potential for
conflict. I'd prefer having something like Debian-rrfw, but be sure to
read up on the flamewars about that topic before you change anything.

The account rrfw should probably be have rrfw as primary group.

The log files should probably be rrfw:adm instead of rrfw:rrfw.

Greetings
Marc

-- 
-----------------------------------------------------------------------------
Marc Haber         | "I don't trust Computers. They | Mailadresse im Header
Karlsruhe, Germany |  lose things."    Winona Ryder | Fon: *49 721 966 32 15
Nordisch by Nature |  How to make an American Quilt | Fax: *49 721 966 31 29