[DRE-commits] [ruby-net-http-persistent] 01/02: Stop testing with explicitly selected SSLv3

[zeha at debian.org]

This is an automated email from the git hooks/post-receive script.

zeha pushed a commit to branch master
in repository ruby-net-http-persistent.

commit 84dbe9765b2618b04872ce0c3bd7d4944af00bd7
Author: Christian Hofstaedtler <zeha at debian.org>
Date:   Sun Nov 9 16:57:36 2014 +0100

    Stop testing with explicitly selected SSLv3
    
    The test server doesn't specify any SSL version preference, so the
    test client can't either. That this worked in the past likely was
    a happy accident.
    
    Closes: #768728
    Thanks-to: Lucas Nussbaum <lucas at lucas-nussbaum.net>
---
 debian/patches/series              |  1 +
 debian/patches/ssl_default_version | 19 +++++++++++++++++++
 2 files changed, 20 insertions(+)

diff --git a/debian/patches/series b/debian/patches/series
index eaed7ec..84333ee 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -1 +1,2 @@
 skip_tests_requiring_net_connectivity
+ssl_default_version
diff --git a/debian/patches/ssl_default_version b/debian/patches/ssl_default_version
new file mode 100644
index 0000000..3df25d5
--- /dev/null
+++ b/debian/patches/ssl_default_version
@@ -0,0 +1,19 @@
+From: Christian Hofstaedtler <zeha at debian.org>
+Subject: let Ruby choose default SSL version
+
+Explicitly using SSLv3 no longer works when we don't say the same
+for the server side. Just let Ruby pick defaults for both test
+server and test client.
+
+Index: ruby-net-http-persistent/test/test_net_http_persistent_ssl_reuse.rb
+===================================================================
+--- ruby-net-http-persistent.orig/test/test_net_http_persistent_ssl_reuse.rb	2014-11-09 16:48:31.000000000 +0100
++++ ruby-net-http-persistent/test/test_net_http_persistent_ssl_reuse.rb	2014-11-09 16:55:49.620098735 +0100
+@@ -87,7 +87,6 @@ class TestNetHttpPersistentSSLReuse < Mi
+ 
+     @http = Net::HTTP::Persistent::SSLReuse.new @host, @port
+     @http.cert_store = store
+-    @http.ssl_version = :SSLv3 if @http.respond_to? :ssl_version=
+     @http.use_ssl = true
+     @http.verify_mode = OpenSSL::SSL::VERIFY_PEER
+ 

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-ruby-extras/ruby-net-http-persistent.git