[DRE-commits] [ruby-capybara] 04/09: Add a patch to inhibit tests requiring launchy

Jérémy Bobbio lunar at moszumanska.debian.org
Wed Sep 9 10:40:58 UTC 2015


This is an automated email from the git hooks/post-receive script.

lunar pushed a commit to branch master
in repository ruby-capybara.

commit 0078c779af3f2eef2baa59d9a5c47e94b6107956
Author: Jérémy Bobbio <lunar at debian.org>
Date:   Wed Sep 9 11:39:53 2015 +0200

    Add a patch to inhibit tests requiring launchy
    
    ruby-launchy is not yet in Debian (#725318).
---
 .../0005-Inhibit-tests-requiring-launchy.patch     | 50 ++++++++++++++++++++++
 debian/patches/series                              |  1 +
 2 files changed, 51 insertions(+)

diff --git a/debian/patches/0005-Inhibit-tests-requiring-launchy.patch b/debian/patches/0005-Inhibit-tests-requiring-launchy.patch
new file mode 100644
index 0000000..d304704
--- /dev/null
+++ b/debian/patches/0005-Inhibit-tests-requiring-launchy.patch
@@ -0,0 +1,50 @@
+From: =?utf-8?q?J=C3=A9r=C3=A9my_Bobbio?= <lunar at debian.org>
+Date: Wed, 9 Sep 2015 11:38:48 +0200
+Subject: Inhibit tests requiring launchy
+
+ruby-launchy is not yet in Debian (#725318) and it's an optional
+dependency of Capybara.
+---
+ lib/capybara/spec/session/save_and_open_page_spec.rb       | 3 +++
+ lib/capybara/spec/session/save_and_open_screenshot_spec.rb | 4 ++--
+ 2 files changed, 5 insertions(+), 2 deletions(-)
+
+diff --git a/lib/capybara/spec/session/save_and_open_page_spec.rb b/lib/capybara/spec/session/save_and_open_page_spec.rb
+index 42e8634..788e61b 100644
+--- a/lib/capybara/spec/session/save_and_open_page_spec.rb
++++ b/lib/capybara/spec/session/save_and_open_page_spec.rb
+@@ -1,3 +1,5 @@
++<<PENDING
++# Waiting for ruby-launchy to be in Debian. ITP #725318
+ require 'launchy'
+ 
+ Capybara::SpecHelper.spec '#save_and_open_page' do
+@@ -17,3 +19,4 @@ Capybara::SpecHelper.spec '#save_and_open_page' do
+     expect(Launchy).to have_received(:open).with(/capybara-\d+\.html/)
+   end
+ end
++PENDING
+diff --git a/lib/capybara/spec/session/save_and_open_screenshot_spec.rb b/lib/capybara/spec/session/save_and_open_screenshot_spec.rb
+index 2e9ddcf..84e2746 100644
+--- a/lib/capybara/spec/session/save_and_open_screenshot_spec.rb
++++ b/lib/capybara/spec/session/save_and_open_screenshot_spec.rb
+@@ -1,10 +1,9 @@
+-require 'launchy'
+-
+ Capybara::SpecHelper.spec '#save_and_open_screenshot' do
+   before do
+     @session.visit '/'
+   end
+ 
++  pending "waiting for launchy to be in Debian" do
+   it 'opens file from the default directory', :requires => [:screenshot] do
+     expected_file_regex = %r{capybara-\d+\.png}
+     allow(@session.driver).to receive(:save_screenshot)
+@@ -28,6 +27,7 @@ Capybara::SpecHelper.spec '#save_and_open_screenshot' do
+       with(custom_path, {})
+     expect(Launchy).to have_received(:open).with(custom_path)
+   end
++  end
+ 
+   context 'when launchy cannot be required' do
+     it 'prints out a correct warning message', :requires => [:screenshot] do
diff --git a/debian/patches/series b/debian/patches/series
index 03a1295..8116ab5 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -2,3 +2,4 @@
 0002-Inhibit-tests-for-the-selenium-driver.patch
 0003-Inhibit-tests-that-needs-more-than-one-driver.patch
 0004-Remove-uneeded-dependency-on-pry-in-tests.patch
+0005-Inhibit-tests-requiring-launchy.patch

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-ruby-extras/ruby-capybara.git



More information about the Pkg-ruby-extras-commits mailing list