[DRE-commits] [ruby-saml] 04/07: disable failing test

Praveen Arimbrathodiyil praveen at moszumanska.debian.org
Sun Jul 10 08:32:25 UTC 2016


This is an automated email from the git hooks/post-receive script.

praveen pushed a commit to branch master
in repository ruby-saml.

commit 97105002c16e73949b5a44660abf5645affaed5d
Author: Praveen Arimbrathodiyil <praveen at debian.org>
Date:   Sun Jul 10 13:10:32 2016 +0530

    disable failing test
---
 debian/patches/disable-failing-test.patch | 35 +++++++++++++++++++++++++++++++
 debian/patches/series                     |  1 +
 2 files changed, 36 insertions(+)

diff --git a/debian/patches/disable-failing-test.patch b/debian/patches/disable-failing-test.patch
new file mode 100644
index 0000000..465a75e
--- /dev/null
+++ b/debian/patches/disable-failing-test.patch
@@ -0,0 +1,35 @@
+File is missing
+https://github.com/onelogin/ruby-saml/issues/338
+
+Index: ruby-saml/test/response_test.rb
+===================================================================
+--- ruby-saml.orig/test/response_test.rb
++++ ruby-saml/test/response_test.rb
+@@ -1289,16 +1289,16 @@ class RubySamlTest < Minitest::Test
+     end
+   end
+ 
+-  describe "attack" do
+-    it "should not be valid" do
+-      settings.private_key = ruby_saml_key_text
+-      signature_wrapping_attack = read_invalid_response("encrypted_new_attack.xml.base64")
+-      response_wrapped = OneLogin::RubySaml::Response.new(signature_wrapping_attack, :settings => settings)
+-      response_wrapped.stubs(:conditions).returns(nil)
+-      response_wrapped.stubs(:validate_subject_confirmation).returns(true)
+-      settings.idp_cert_fingerprint = "385b1eec71143f00db6af936e2ea12a28771d72c"
+-      assert !response_wrapped.is_valid?
+-    end
+-  end
++ # describe "attack" do
++ #   it "should not be valid" do
++ #     settings.private_key = ruby_saml_key_text
++ #     signature_wrapping_attack = read_invalid_response("encrypted_new_attack.xml.base64")
++ #     response_wrapped = OneLogin::RubySaml::Response.new(signature_wrapping_attack, :settings => settings)
++ #     response_wrapped.stubs(:conditions).returns(nil)
++ #     response_wrapped.stubs(:validate_subject_confirmation).returns(true)
++ #     settings.idp_cert_fingerprint = "385b1eec71143f00db6af936e2ea12a28771d72c"
++ #     assert !response_wrapped.is_valid?
++ #   end
++ # end
+ 
+ end
diff --git a/debian/patches/series b/debian/patches/series
index 2c2f2bc..b1ef9bf 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -1,3 +1,4 @@
 remove-simplecov.patch
 remove-bundler.patch
 use-unshift-in-gemspec.patch
+disable-failing-test.patch

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-ruby-extras/ruby-saml.git



More information about the Pkg-ruby-extras-commits mailing list