[DRE-commits] [librarian-puppet] 39/153: Issue #235 Error when forge is not defined in Puppetfile

[Stig Sandbeck Mathisen]

This is an automated email from the git hooks/post-receive script.

ssm pushed a commit to branch master
in repository librarian-puppet.

commit ee9c7a91e49d139f1f391081aedf739f71605da6
Author: Carlos Sanchez <csanchez at maestrodev.com>
Date:   Sat Aug 2 11:47:29 2014 +0200

    Issue #235 Error when forge is not defined in Puppetfile
---
 features/install/forge.feature    | 9 +++++++++
 lib/librarian/puppet/extension.rb | 3 +++
 2 files changed, 12 insertions(+)

diff --git a/features/install/forge.feature b/features/install/forge.feature
index 1f953d8..805e227 100644
--- a/features/install/forge.feature
+++ b/features/install/forge.feature
@@ -42,6 +42,15 @@ Feature: cli/install/forge
     Then the exit status should be 0
     And the file "modules/stdlib/metadata.json" should match /"name": "puppetlabs-stdlib"/
 
+  Scenario: Installing a module without forge
+    Given a file named "Puppetfile" with:
+    """
+    mod 'puppetlabs/stdlib', '4.1.0'
+    """
+    When I run `librarian-puppet install`
+    Then the exit status should be 1
+    And the output should contain "forge entry is not defined in Puppetfile"
+
   Scenario: Installing an exact version of a module
     Given a file named "Puppetfile" with:
     """
diff --git a/lib/librarian/puppet/extension.rb b/lib/librarian/puppet/extension.rb
index af1134b..48c7a9a 100644
--- a/lib/librarian/puppet/extension.rb
+++ b/lib/librarian/puppet/extension.rb
@@ -13,6 +13,9 @@ module Librarian
     def initialize(name, requirement, source)
       assert_name_valid! name
 
+      # Issue #235 fail if forge source is not defined
+      raise Error, "forge entry is not defined in Puppetfile" if source.instance_of?(Array) && source.empty?
+
       # let's settle on provider-module syntax instead of provider/module
       self.name = normalize_name(name)
       self.requirement = Requirement.new(requirement)

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-ruby-extras/librarian-puppet.git