[DRE-commits] [ruby-appraiser] 01/02: Fix package tests

[Lucas Moura]

This is an automated email from the git hooks/post-receive script.

lucasmoura-guest pushed a commit to branch master
in repository ruby-appraiser.

commit a3993183a380de3a1637c334b2b1e90046274ccb
Author: Lucas Albuquerque Medeiros de Moura <lucas.moura128 at gmail.com>
Date:   Thu Mar 3 17:16:59 2016 -0300

    Fix package tests
---
 debian/changelog                    |  9 +++++
 debian/patches/fix_stub_tests.patch | 76 +++++++++++++++++++++++++++++++++++++
 debian/patches/series               |  1 +
 3 files changed, 86 insertions(+)

diff --git a/debian/changelog b/debian/changelog
index 9cf96c6..a75baa9 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,12 @@
+ruby-appraiser (0.2.0-3) unstable; urgency=medium
+
+  * Team upload.
+  * Fix package tests.
+    - Replace stub calls for double ones.
+    - Change rspec "have" method for "eq" method.
+
+ -- Lucas Albuquerque Medeiros de Moura <lucas.moura128 at gmail.com>  Thu, 03 Mar 2016 18:02:58 -0300
+
 ruby-appraiser (0.2.0-2) unstable; urgency=medium
 
   * debian/rules: add DH_RUBY option to fix conflicts with yard.
diff --git a/debian/patches/fix_stub_tests.patch b/debian/patches/fix_stub_tests.patch
new file mode 100644
index 0000000..0b458f6
--- /dev/null
+++ b/debian/patches/fix_stub_tests.patch
@@ -0,0 +1,76 @@
+Description: Fix package tests
+ This patches basically replaces the stub method calls for double ones. It also
+ updates a test using the deprecated rspec "have" method for the "eq" one.
+
+ Both of these fixes can actually be found on the upstream. However, since a new
+ release on rubygems was not generated, this patch was them necessary.
+
+Author: Lucas Albuquerque Medeiros de Moura <lucas.moura128 at gmail.com>
+Last-updated: 2016-03-03
+Forwarded: not-needed 
+Bug: not-needed
+
+
+Index: ruby-appraiser/spec/appraiser_spec.rb
+===================================================================
+--- ruby-appraiser.orig/spec/appraiser_spec.rb	2016-03-03 17:27:42.384146595 -0300
++++ ruby-appraiser/spec/appraiser_spec.rb	2016-03-03 17:28:32.324054721 -0300
+@@ -47,13 +47,13 @@
+ 
+   describe "#process(output)" do
+     let(:command) { Gem::Commands::AppraiserCommand.new }
+-    let(:output) { stub(IO).as_null_object }
++    let(:output) { double('IO').as_null_object }
+ 
+     context "response body is not empty json" do
+       before do
+         dependencies = []
+-        dependencies << stub(Bundler::Dependency, :groups => [:default], :name => 'rails')
+-        dependencies << stub(Bundler::Dependency, :groups => [:test], :name => 'rspec')
++        dependencies << double('Bundler::Dependency', :groups => [:default], :name => 'rails')
++        dependencies << double('Bundler::Dependency', :groups => [:test], :name => 'rspec')
+         Bundler.stub_chain(:definition, :dependencies) { dependencies }
+       end
+ 
+@@ -76,10 +76,10 @@
+ 
+     context "response body is empty json" do
+       before do
+-        @dependency = stub(Bundler::Dependency,
+-                           :groups => [:default],
+-                           :name => 'rails',
+-                           :source => 'git://github.com/tenderlove/nokogiri.git')
++        @dependency = double('Bundler::Dependency',
++                             :groups => [:default],
++                             :name => 'rails',
++                             :source => 'git://github.com/tenderlove/nokogiri.git')
+         Bundler.stub_chain(:definition, :dependencies) { [@dependency] }
+ 
+         stub_request(:get, 'http://rubygems.org/api/v1/gems/rails.json').
+@@ -106,7 +106,7 @@
+     context "open() raises OpenURI::HTTPError exception" do
+       before do
+         stub_request(:get, 'http://rubygems.org/api/v1/gems/rails.json').
+-          to_raise(OpenURI::HTTPError.new('error', stub(StringIO)))
++          to_raise(OpenURI::HTTPError.new('error', double('StringIO')))
+       end
+ 
+       subject { command.send(:load_json, gem_name) }
+@@ -166,13 +166,13 @@
+ 
+     it "should call Bundler.definition.dependencies.select" do
+       dependencies = []
+-      dependencies << stub(Bundler::Dependency, :groups => [:default])
+-      dependencies << stub(Bundler::Dependency, :groups => [:development])
+-      dependencies << stub(Bundler::Dependency, :groups => [:development, :test])
++      dependencies << double('Bundler::Dependency', :groups => [:default])
++      dependencies << double('Bundler::Dependency', :groups => [:development])
++      dependencies << double('Bundler::Dependency', :groups => [:development, :test])
+       Bundler.stub_chain(:definition, :dependencies) { dependencies }
+ 
+       result = command.send(:dependencies_for, group)
+-      expect(result).to have(2).dependencies
++      expect(result.size).to eq(2)
+     end
+   end
+ 
diff --git a/debian/patches/series b/debian/patches/series
new file mode 100644
index 0000000..d391fe2
--- /dev/null
+++ b/debian/patches/series
@@ -0,0 +1 @@
+fix_stub_tests.patch

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-ruby-extras/ruby-appraiser.git