[Pkg-running-devel] quickroute-gps debian package

[Kristof Ralovich]

On Wed, 2015-11-25 at 07:22 +0100, Christian PERRIER wrote:
> Quoting Kristof Ralovich (kristof.ralovich at gmail.com):
> 
> > 2.4-10 is uploaded, aiming to address the build-depends problem. Now I
> > was able to build the package on hosts without mono development packages
> > (xbuild, cli-common-dev) installed. However for this to work, one needs
> > to pass the "-d" option to gbp buildpackage.
> > 
> > Would you please take look, test it and upload if possible?
> 
> It built fine, thanks.
> 
> Maybe may you check at the following lintian warnings?


Thank you for reviewing the package. Inline comments below.

> 
> W: quickroute-gps source: package-needs-versioned-debhelper-build-depends 9

Updated to require debhelper >= 9.

> N: 
> N:    The package either doesn't declare a versioned build dependency on
> N:    debhelper or does not declare a versioned build dependency on a new
> N:    enough version of debhelper to satisfy the declared compatibility level.
> N:    
> N:    The required version of debhelper is not guaranteed to be satisfied in
> N:    all supported releases of Debian and therefore this may lead to a build
> N:    failure.
> N:    
> N:    Recommended practice is to always declare an explicit versioned
> N:    dependency on debhelper equal to or greater than the compatibility level
> N:    used by the package, even if the versioned dependency isn't strictly
> N:    necessary. Having a versioned dependency also helps with backports to
> N:    older releases and correct builds on partially updated systems.
> N:    
> N:    Note if you are using a compat level, which is marked as experimental,
> N:    such as compat 9 in debhelper 8.1.3, then please override this tag.
> N:    
> N:    Refer to the debhelper(7) manual page for details.
> N:    
> N:    Severity: minor, Certainty: certain
> N:    
> N:    Check: debhelper, Type: source
> N: 
> W: quickroute-gps source: obsolete-url-in-packaging debian/copyright https://code.google.com/p/exiflibrary/

I am not aware of a "newer" upstream for this library. It seems to have
not been updated sine 2014.

> N: 
> N:    One of the package's packaging files points to a website or code hoster
> N:    known to have frozen contents, to be closed soon or to have already
> N:    closed.
> N:    
> N:    Please look for the new upstream home of the package and update the
> N:    packaging accordingly.
> N:    
> N:    Sites previously hosted on code.google.com were offered a migration to
> N:    github.com, sites previously on gitorious.org were offered a migration
> N:    to gitlab.com. You might want to look there first.
> N:    
> N:    Severity: normal, Certainty: certain
> N:    
> N:    Check: obsolete-sites, Type: source
> N: 
> W: quickroute-gps source: syntax-error-in-dep5-copyright line 35: Continuation line outside a paragraph (maybe line 34 should be " .").

Should be fixed by now.

> N: 
> N:    The machine-readable copyright file didn't pass Debian control file
> N:    syntax check.
> N:    
> N:    This issue may hide other issues as Lintian skips some checks on the
> N:    file in this case.
> N:    
> N:    Refer to
> N:    https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/ for
> N:    details.
> N:    
> N:    Severity: normal, Certainty: possible
> N:    
> N:    Check: source-copyright, Type: source
> N: 
> P: quickroute-gps: no-upstream-changelog

Upstream does not provide a change log other than the version control
history. I do not know how to address this.

> N: 
> N:    The package does not install an upstream changelog file. If upstream
> N:    provides a changelog, it should be accessible as
> N:    /usr/share/doc/<pkg>/changelog.gz.
> N:    
> N:    It's currently unclear how best to handle multiple binary packages from
> N:    the same source. Some maintainers put a copy of the upstream changelog
> N:    in each package, but it can be quite long. Some include it in one
> N:    package and add symlinks to the other packages, but this requires there
> N:    be dependencies between the packages. Some only include it in a
> N:    "central" binary package and omit it from more ancillary packages.
> N:    
> N:    Refer to Debian Policy Manual section 12.7 (Changelog files) for
> N:    details.
> N:    
> N:    Severity: pedantic, Certainty: wild-guess
> N:    
> N:    Check: changelog-file, Type: binary
> N: 
> W: quickroute-gps: command-in-menu-file-and-desktop-file quickroute-gps usr/share/menu/quickroute-gps:6

Menu file removed.

> N: 
> N:    The command is listed both in a menu file and a desktop file
> N:    
> N:    Per the tech-ctte decision on #741573, this is now prohibited.
> N:    
> N:    Please remove the reference from the menu file.
> N:    
> N:    Refer to
> N:    https://lists.debian.org/debian-devel-announce/2015/09/msg00000.html for
> N:    details.
> N:    
> N:    Severity: normal, Certainty: possible
> N:    
> N:    Check: menu-format, Type: binary
> N: 

2.4-11 contains the above fixes. Would you please test and upload?

Thank you,
Kristof