[Pkg-scicomp-devel] Bug#455670: patch

[Ondrej Certik]

On 3/30/08, Maximiliano Curia <maxy at gnuservers.com.ar> wrote:
> Hola Ondrej Certik!
>
> El 26/03/2008 a las 16:03 escribiste:
> > If you commit it into our svn, sure I'll upload it. Otherwise I need
> > to find time for this first - maybe Adam will do it before me. :)
>
> I've packaged the new upstream release of libmesh, tried to fix most of the
> bugs,
> and made it available [1]. There are a few issues that need review, which I
> don't fully understand: there were some dpkg-shlibdeps warnings that led me
> to
> disable metis, netcdf and exodus support, the warnings were of the style:
>
> dpkg-shlibdeps: warning: symbol ex_put_elem_block used by
> debian/libmesh0.6.2/usr/lib/libmesh.so.0.6.2 found in none of the libraries
>
> I'm not sure why libmesh.so is not being linked against libexodus.so,
> libnetcdf.so or libmetis.
>
> Also, if you have some way of checking ABI compatibility, it would be great.
> As
> I was not able to check it and I afraid there might be some ABI breakage.
>
> In any case, I don't have access to the svn, so if you accept it please
> commit it.
>
> [1]: http://www.maxy.com.ar/~maxy/libmesh/

OK, I checked it and your changes are very good indeed. The package
builds. Here are lintian warnigs:


$ lintian libmesh_0.6.2.dfsg-0.1_amd64.changes
E: libmesh_0.6.2.dfsg-0.1_amd64.changes:
bad-distribution-in-changes-file UNRELEASED
W: libmesh source: changelog-should-mention-nmu
W: libmesh0.6.2-dev: cvsignore-file-in-package
usr/share/doc/libmesh0.6.2-dev/examples/ex0/.cvsignore
W: libmesh0.6.2-dev: cvsignore-file-in-package
usr/share/doc/libmesh0.6.2-dev/examples/ex1/.cvsignore
W: libmesh0.6.2-dev: cvsignore-file-in-package
usr/share/doc/libmesh0.6.2-dev/examples/ex10/.cvsignore
W: libmesh0.6.2-dev: cvsignore-file-in-package
usr/share/doc/libmesh0.6.2-dev/examples/ex11/.cvsignore
W: libmesh0.6.2-dev: cvsignore-file-in-package
usr/share/doc/libmesh0.6.2-dev/examples/ex12/.cvsignore
W: libmesh0.6.2-dev: cvsignore-file-in-package
usr/share/doc/libmesh0.6.2-dev/examples/ex13/.cvsignore
W: libmesh0.6.2-dev: cvsignore-file-in-package
usr/share/doc/libmesh0.6.2-dev/examples/ex14/.cvsignore
W: libmesh0.6.2-dev: cvsignore-file-in-package
usr/share/doc/libmesh0.6.2-dev/examples/ex15/.cvsignore
W: libmesh0.6.2-dev: cvsignore-file-in-package
usr/share/doc/libmesh0.6.2-dev/examples/ex16/.cvsignore
W: libmesh0.6.2-dev: cvsignore-file-in-package
usr/share/doc/libmesh0.6.2-dev/examples/ex17/.cvsignore
W: libmesh0.6.2-dev: cvsignore-file-in-package
usr/share/doc/libmesh0.6.2-dev/examples/ex18/.cvsignore
W: libmesh0.6.2-dev: cvsignore-file-in-package
usr/share/doc/libmesh0.6.2-dev/examples/ex2/.cvsignore
W: libmesh0.6.2-dev: cvsignore-file-in-package
usr/share/doc/libmesh0.6.2-dev/examples/ex3/.cvsignore
W: libmesh0.6.2-dev: cvsignore-file-in-package
usr/share/doc/libmesh0.6.2-dev/examples/ex4/.cvsignore
W: libmesh0.6.2-dev: cvsignore-file-in-package
usr/share/doc/libmesh0.6.2-dev/examples/ex5/.cvsignore
W: libmesh0.6.2-dev: cvsignore-file-in-package
usr/share/doc/libmesh0.6.2-dev/examples/ex6/.cvsignore
W: libmesh0.6.2-dev: cvsignore-file-in-package
usr/share/doc/libmesh0.6.2-dev/examples/ex7/.cvsignore
W: libmesh0.6.2-dev: cvsignore-file-in-package
usr/share/doc/libmesh0.6.2-dev/examples/ex8/.cvsignore
W: libmesh0.6.2-dev: cvsignore-file-in-package
usr/share/doc/libmesh0.6.2-dev/examples/ex9/.cvsignore

Basically, the .cvsignore should be deleted from the upstream tarball.
The first two warnings are trivially fixed in the changelog. I set it
to UNRELEASED for now. Adam or Christophe - could you please upload?
(I, as a DM, cannot upload new binary packages, only new revisions)

Christophe - could you please add Maximiliano to our team, so that he
can edit our svn?

Thanks,
Ondrej