[Pkg-security-team] Review of ncrack and t50

[Raphael Hertzog]

On Mon, 25 Jul 2016, Marcos Fouces wrote:
> > I: ncrack: spelling-error-in-binary usr/bin/ncrack addres address
> This is a variable in source code: if (!strncmp(buf, "addres", 6))
> 
> I don't know if it should be fixed. Please, re-check it in the
> ncrack_input.cc file (line 198).

Right, this one should not be fixed. Then add a lintian override
explaining that it's not a typo but a substring match.

Uploaded the current package anyway.

> > For t50:
> > * why do you override dh_strip in the way you do it?
> Because the default behavior of dh_strip creates an extra  dbg_sym package
> at building time and Lintian complained about it. This way the binaries are
> also stripped (hopefully) and there is no extra debug package.

We actually want the "*-dbgsym" packages, it's a recent feature enabled in
debhelper (automatic debug packages).

What did lintian say? Do you have the latest version of lintian?

Cheers,
-- 
Raphaël Hertzog ◈ Debian Developer

Support Debian LTS: http://www.freexian.com/services/debian-lts.html
Learn to master Debian: http://debian-handbook.info/get/