Bug#849695: sslsniff: libraries should be linked in LDADD, not LDFLAGS (FTBFS with ld --as-needed)

[Logan Rosen]

Package: sslsniff
Version: 0.8-6
Severity: normal
Tags: patch
User: ubuntu-devel at lists.ubuntu.com
Usertags: origin-ubuntu zesty ubuntu-patch

Dear Maintainer,

In Makefile.am, libraries are linked against in LDFLAGS (which is meant for
linker options), not LDADD. This causes an FTBFS with ld --as-needed in
Ubuntu, where the order of linking matters.

See https://wiki.debian.org/ToolChain/DSOLinking#Only_link_with_needed_libraries for more
information.

In Ubuntu, the attached patch was applied to achieve the following:

  * debian/patches/Add-missing-libraries-at-link-time.patch: Update to add
    libraries to LDADD instead of LDFLAGS, fixing FTBFS with ld --as-needed.

Thanks for considering the patch.

Logan Rosen

-- System Information:
Debian Release: stretch/sid
  APT prefers yakkety-updates
  APT policy: (500, 'yakkety-updates'), (500, 'yakkety-security'), (500, 'yakkety'), (100, 'yakkety-backports')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.4.0-21-generic (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8) (ignored: LC_ALL set to en_US.utf8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: sslsniff_0.8-6ubuntu1.debdiff
Type: text/x-diff
Size: 1745 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-security-team/attachments/20161229/e0b5db05/attachment.diff>