packaging dnsmap

[Samuel Henrique]

Ok, here's my review of the package:

What needs to be done in order for the upload to be approved (by me, i know
there are other DDs who doesn't mind some problems that i'm considering
here):

a) Bump DH level to 10: You're currently using DH 9.

b) Declare a proper DH version on d/control: Please have a look at [1], and
bare in mind that you will be using DH 10 in your case.

c) Remove the watchfile: It is pointing to code.google, which is obsolete
and won't have any new releases (besides upstream is non-active for at last
7 years).

d) Remove double GPL-2+ definition: More information here[2].

e) Remove debhelper template from d/copyright: Looks like you forgot to
have a look at line 6.

f) Add yourself on d/copyright: After all, you did changes to the packaging
and now you can add yourself as one of the copyright holders of debian/*

h) Open an ITP bug and close it using d/changelog: Please read this[3].

i) Remove trailing whitespaces: I can see a lot of them on d/control and on
on d/rules, you can either use $ wrap-and-sort -a or enable trailing
whitespace highlighting on vim[4], i recommend you to use wrap-and-sort to
fix this.

j) Remove dh comments from d/rules: Self explanatory.

k) Remove d/docs: None of the files there is useful, the only one that is
arguable (is a doc in fact) is README.txt, but a manpage should make it
useless.

l) Patch Makefile: The makefile is missing CPPFLAGS, LFDLAGS and the CFLAGS
is being overriden (which causes a useless -dbgsym package), please have a
look at[5] for hints on how to fix that. After that you may also add "export
DEB_BUILD_MAINT_OPTIONS = hardening=+all" at d/rules in order to enable
bindnow.

m) Rename dnsmap-bulk.sh to dnsmap-bulk: We are encouraged not to ship
script files with language extensions, you can read more about this here[6].

n) Remove d/dirs: it is not needed to put usr/bin there and
usr/share/dnsmap is already being used on d/dnsmap.install, more info[7].

o) Bonus: Create a manpage: I consider this important, shouldn't be so
trouble since one can use info already provided on README.txt.

That's all, i know that there are a lot of points, please don't be
discouraged by my review, most of these problems are newbie ones and i
believe you won't be committing them again.

If you have any questions about how to do any of these changes, or feel
like not having time to do them, please reply and i can help you. If you're
planning to become a DM/DD, its better if you do the changes yourself.

After all these changes are made, i can have another look at the package
just to confirm that i didn't missed anything (i'm pretty sure i not).

[1]https://www.debian.org/doc/manuals/maint-guide/dreq.en.html#control
[2]https://lintian.debian.org/tags/dep5-copyright-license-
name-not-unique.html
[3]https://www.debian.org/doc/manuals/developers-reference/
pkgs.html#newpackage
[4]Put this in your .vimrc: inoremap <F2> <CR><C-R>=repeat('
',col([line('.')-1,'$'])-col('.'))<CR><C-O>:.retab<CR>
[5]http://eriberto.pro.br/blog/?p=2222
[6]https://www.debian.org/doc/debian-policy/ch-files.html ['10.4 Scripts'
paragraph]
[7]https://www.debian.org/doc/manuals/maint-guide/dother.en.html#dirs

Regards, and happy new year.

Samuel Henrique <samueloph>

2016-12-30 23:43 GMT-02:00 Samuel Henrique <samueloph at gmail.com>:

> Sure, i would like to do that!
>
> Just give me 14 hours and i will reply here with my review (i'm gonna do
> it tomorrow).
>
> Samuel Henrique <samueloph>
>
> 2016-12-30 19:40 GMT-02:00 Gianfranco Costamagna <locutusofborg at debian.org
> >:
>
>> Hello,
>>
>> >hello guys, i have packaged dnsmap and then adjusted some d/rules things
>> by watching to the kali package, is someone interested in checking if
>> everything is ok?
>>
>>
>> there are some improvements that I would like to add, but I prefer
>> somebody else to do the review :)
>>
>> Samuel, can you please give it a look?
>>
>> I see something like 4 things I would like to see fixed before sponsoring
>> :p
>>
>>
>> G.
>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.alioth.debian.org/pipermail/pkg-security-team/attachments/20161231/dee1c6d2/attachment.html>