Ask for review

[Raphael Hertzog]

Hello Marcos,

I started to review and sponsor the various packages.

I sponsored knocker mostly as-is. For dsniff, I made some
minor changes only and sponsored it. For recon-ng, I switched
to a newer upstream release and I had to revert a change
of yours that did not make any sense (replaced python-olefile
which exists by olefile which doesn't exist) but apart from that it was
good.

Now I'm reviewing libnids and here I have a problem. Your update
currently involves a library transition (libnids1.21 to libnids1.24)
but the upstream changes are very small and are likely to not
break the API/ABI of the library.

We already had version 1.23 in the package libnids1.21 and I don't
understand why you decided to rename the package and the library.

Your commit 5cfd332ab78a57919fdaf19422c43d59e6351563 ("Refresh and
sanitize patches") is actually dropping our patch which kept the old
library name:

---- libnids-1.23.orig/src/Makefile.in
-+++ libnids-1.23/src/Makefile.in
-@@ -13,7 +13,7 @@ includedir   = @includedir@
- libdir                = @libdir@
- mandir                = @mandir@
- LIBSTATIC      = libnids.a
--LIBSHARED      = libnids.so.1.23
-+LIBSHARED      = libnids.so.1.21
- 
- CC            = @CC@
- CFLAGS                = @CFLAGS@ -W -Wall -DLIBNET_VER=@LIBNET_VER@ -DHAVE_ICMPHDR=@ICMPHEADER@ -DHAVE_TCP_STATES=@TCPSTATES@ -DHAVE_BSD_UDPHDR=@HAVE_BSD_UDPHDR@

You should reintroduce this as a proper standalone patch
(change-library-soname.patch for example) and revert your changes related to this
(reinstate ibnids1.21 in debian/control and switch back to former symbols file).

I'm stopping here for libnids. Please do those updates, ensure that current dsniff
is working fine with the updated libnids1.21 and then ping me again to finish my review
and upload.

Cheers,

On Sun, 09 Apr 2017, Marcos Fouces wrote:
> Hi team!
> 
> I had some spare time and i decided to try to adopt some security-related
> orphaned packages.
> 
> Should be good if someone could review them.
> 
> * https://anonscm.debian.org/cgit/pkg-security/knocker.git/
> 
> * https://anonscm.debian.org/cgit/pkg-security/libnids.git/
> 
> * https://anonscm.debian.org/cgit/pkg-security/rfdump.git/
> 
> * https://anonscm.debian.org/cgit/pkg-security/snoopy.git/
> 
> * https://anonscm.debian.org/cgit/pkg-security/swatch.git/
> 
> I also fixed some bugs, Lintian warnings, new release...  in the following
> packages:
> 
> * https://anonscm.debian.org/cgit/pkg-security/dsniff.git/
> 
> * https://anonscm.debian.org/cgit/pkg-security/autolog.git/
> 
> * https://anonscm.debian.org/cgit/pkg-security/acct.git/
> 
> * https://anonscm.debian.org/cgit/pkg-security/recon-ng.git/
> 
> Could someone review them?
> 
> Thanks for your time.
> 
> Greetings,
> 
> Marcos
> 
> 
> 

-- 
Raphaël Hertzog ◈ Debian Developer

Support Debian LTS: https://www.freexian.com/services/debian-lts.html
Learn to master Debian: https://debian-handbook.info/get/