Ask for review

[Raphael Hertzog]

Hi,

On Sat, 22 Apr 2017, Lukas Schwaighofer wrote:
> * calling ./bootstrap.sh (in debian/rules) is unnecessary; it only
>   performs what the dh_autoreconf sequence does anyways. This also
>   means you can drop one of the patches…

Ack.

> * you disabled the test suite completely. I think it would be better to
>   keep as much as possible around. After adding procps to the
>   build-depends, four tests fail in my enivornment:
>   - datasource_egid.sh
>   - datasource_egroup.sh
>   - combined-filter-exclude_uid-drop.sh
>   - combined-filter-only_uid-pass.sh
>   The tests probably fail due to pbuilder's build environment (uid
>   mismatch between what snoopy thinks and what's reported by `ps`). If
>   I disable those four (in tests/combined/Makefile.am and
>   tests/datasource/Makefile.am using a patch) the build works.

It's better to keep as many tests as possible. So I prefer to disable
only the tests that are failing... but it would be even better if we could
fix the tests to actually work.

> I have not pushed any of the changes to the repository because I'm not
> sure if you prefer keeping the test suite completely disabled.

Please go ahead with your changes. There's no strong package ownership
within pkg-security.

Cheers,
-- 
Raphaël Hertzog ◈ Debian Developer

Support Debian LTS: https://www.freexian.com/services/debian-lts.html
Learn to master Debian: https://debian-handbook.info/get/