[pkg][dhcpig] ready for review

[Raphael Hertzog]

Hello Phil,

On Mon, 19 Jun 2017, phil at reseau-libre.net wrote:
> Because there is no upstream tag/release, it is based on epoch+git timestamp
> (i.e. uversion = 0:1.0+git20170428-1). I posted an issue on the mainstream
> project to ask if it is possible to have tags/github releases.

This is not the correct version to use. First of "0:" is exactly the same
as no epoch at all. Then when you don't have any upstream version, you
should certainly not assume that 1.0 is acceptable. You should aim for the
lowest possible version for example 0~git20170428-1. Then you will be fine
even if upstream releases the next version as 0.0.1 (~ is lower than
anything else).

Other comments:
- please submit your patches upstream, both help.patch and
  pybuild_mode.patch are "upstreamable"
- "XS-Python-Version: >= 2.7" in debian/control is sort of useless,
  we have a single python 2 version currently and for the future...
- you don't need to hardcode the "python" dependency in the Depends
  of dhcpig, it's generated as part of ${python:Depends}.
- please use "https" for the Format line in debian/copyright
- please rename debian/docs into debian/dhcpig.docs and debian/manpages
  into debian/dhcpig.manpages, the idea is to cleanly separate files
  that apply to binary packages from files that apply to the source
  package as a whole
- I see that you always bother to create an upstream changelog with some
  custom rules in debian/rules and a quilt patch, it's nice but you don't
  have to do that... it's fine if there is no upstream changelog in the
  package.
- in debian/rules I see you pass "-O--buildsystem=pybuild" to
  dh_auto_build and dh_install... it should not be needed. The "dh $@
  --with python2 --buildsystem=pybuild" call is already setting everything
  required so that all dh_* commands know which buildsystem is in use
  (IIRC it uses some environment variables to do this)
- can you explain the following two lines?
# redirect module to correct dist-packages dir
export PYBUILD_INSTALL_ARGS=--install-lib=/usr/lib/python2.7/dist-packages
- note that help.patch contains an unrelated change (adding parenthesis to a
  print call, it's nice for Python 3 compat but doesn't change anything
  otherwise)

Cheers,
-- 
Raphaël Hertzog ◈ Debian Developer

Support Debian LTS: https://www.freexian.com/services/debian-lts.html
Learn to master Debian: https://debian-handbook.info/get/