[pkg] CurveDNS - review

[Lukas Schwaighofer]

Hi Stéphane,

On Thu, 22 Jun 2017 15:15:46 +0200
Stéphane Neveu <stefneveu at gmail.com> wrote:

> > [regarding linking curvedns against libsodium]
> I had a look at how it' done for FreeBSD. Here is my try to do the
> same, so two patches added :
> - libsodium.patch
> - makefile.patch

Great, that sounds very promising indeed!  I only looked at it briefly,
I'll take a proper look next week (I'm busy on the weekend).  I noticed
that there is no attribution in any of the patches.  If you based your
patches on something from FreeBSD, you should add some form of
attribution.


> > [regarding improvement of debian/curvedns.config script]
> Yes, I agree with you. I'm still working on it, I'm trying to add some
> more controls but for now the db_input high curvedns/ask_again is now
> showing up... Still need to work on this like you said :)

Sounds good, let me know when it's ready for review.

> Note : I also added db_purge in postrm.

You shouldn't need to add that manually. The code to do that should be
automatically inserted where you placed the #DEBHELPER# placeholder
(by dh_installdebconf).  If you want to make sure it's done, extract
the control information from your binary package after a build using
`dpkg -e` and check the final script.


> > [regarding other improvements of
> > debian/curvedns.{postinst,postrm,prerm} ]
> Is it a bit better ?

Yes, better :) .

In curvedns.prerem you got the negation wrong: in the `if` statement
the "-a" for and needs to become an "-o" for or (mind the De Morgan's
laws when negating).


As noted above, I won't be available on the weekend (so don't take
my lack of response for a lack of interest).  I've only spent little
time just now to look at your recent changes; however, I see you have
put good work into the packaging!

I will make a more thorough review next week (including actually
building the package which admittedly I haven't done so far…).

Good night
Lukas
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-security-team/attachments/20170623/c67610c7/attachment.sig>