[pkg][dhcpig] ready for review

[Raphael Hertzog]

[ You need to stop putting into CC the
pkg-security-team-bounces+phil=reseau-libre.net at lists.alioth.debian.org
email address, I wonder how you manage that, it's only in the envelope
from in theory... but I get mails about unknown bounces due to that ]

On Fri, 23 Jun 2017, phil at reseau-libre.net wrote:
> Thank you for this complete explanation on how to manage untagged upstream.
> I've seen various ways to handle them, nearly all different :-/
> I've updated as you explained.

The important part is to start with "0~", the part afterwards is usually
a date (so that we can do regular snapshots and have a linear increase in
version), sometimes with an additional git commit to make it clear what
commit has been snapshotted.

> > Other comments:
> > - please submit your patches upstream, both help.patch and
> >   pybuild_mode.patch are "upstreamable"
> 
> Done :)

Then please indicate it in the patch headers, I want to see:
Bug: https://github.com/.../issue/XXX
or something like that (cf DEP-3 http://dep.debian.net/deps/dep3/).

> > - "XS-Python-Version: >= 2.7" in debian/control is sort of useless,
> >   we have a single python 2 version currently and for the future...
> 
> Updated also. I've replaced '>= 2.7' with 'all', if it is what you imagined.

No, I imagined that you would remove the field entirely. It serves no
purpose at all.

> > - please rename debian/docs into debian/dhcpig.docs and debian/manpages
> >   into debian/dhcpig.manpages, the idea is to cleanly separate files
> >   that apply to binary packages from files that apply to the source
> >   package as a whole
> 
> I have to take this habit... :) Done.

Note that it's more a personal preference of mine than a hard rule.

> Ok i thought it was better to have one. I cleaned the content.

You do what you prefer, I just tell you that you are not forced to do
this changelog generation.

> not the case of dhcpig - i also made a little script to get back the
> changelog from github. In this case i imagine that i can keep the script to
> get it back ?

Of course, even here you can keep your changelog generation if you believe
it's important.

> > - can you explain the following two lines?
> > # redirect module to correct dist-packages dir
> > export
> > PYBUILD_INSTALL_ARGS=--install-lib=/usr/lib/python2.7/dist-packages
> 
> I didn't remember well why, but when i started the packaging of another
> python pkg, the installation was not made in this directory but in another
> one (i thought it was for a python3 package, and the install was in
> /usr/lib/python3.5/dist-packages instead of /usr/lib/python3/dist-packages,
> making lintian complain.
> In that case i have no errors without that line.

So drop it. :)

> I've also updated standards-version to 4.0.0.

I let you do the two or three small changes left and then I'll upload the
package.

Cheers,
-- 
Raphaël Hertzog ◈ Debian Developer

Support Debian LTS: https://www.freexian.com/services/debian-lts.html
Learn to master Debian: https://debian-handbook.info/get/